From: Stephen Chandler Paul <cpaul@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>, Andreas Mohr <andi@lisas.de>
Subject: Re: [PATCH v5] i8042: Add unmask_kbd_data option
Date: Wed, 15 Jul 2015 13:16:10 -0400 [thread overview]
Message-ID: <1436980570.10553.0.camel@redhat.com> (raw)
In-Reply-To: <20150715165954.GA19828@dtor-ws>
On Wed, 2015-07-15 at 09:59 -0700, Dmitry Torokhov wrote:
> Hi Stephen,
>
> On Thu, Jul 02, 2015 at 11:46:48AM -0400, cpaul@redhat.com wrote:
> > +static int i8042_kbd_bind_notifier(struct notifier_block *nb,
> > + unsigned long action, void
> > *data)
> > +{
> > + struct device *dev = data;
> > + struct serio *serio = to_serio_port(dev);
> > + struct i8042_port *port = serio->port_data;
> > +
> > + if (serio != i8042_ports[I8042_KBD_PORT_NO].serio)
> > + return 0;
> > +
> > + switch (action) {
> > + case BUS_NOTIFY_BOUND_DRIVER:
> > + port->driver_bound = true;
> > + break;
> > +
> > + case BUS_NOTIFY_UNBOUND_DRIVER:
>
> I think it should be BUS_NOTIFY_UNBIND_DRIVER so that we see the KBD
> data as it goes through driver cleanup. Yell if you disagree, or I'll
> change it locally.
Sounds good to me
Cheers,
Stephen Chandler Paul
>
> Thanks.
>
prev parent reply other threads:[~2015-07-15 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 20:35 [PATCH v4] i8042: Add debug_kbd option Andreas Mohr
2015-07-02 15:46 ` [PATCH v5] i8042: Add unmask_kbd_data option cpaul
2015-07-03 12:05 ` Andreas Mohr
2015-07-15 15:28 ` Benjamin Tissoires
2015-07-15 16:59 ` Dmitry Torokhov
2015-07-15 17:16 ` Stephen Chandler Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436980570.10553.0.camel@redhat.com \
--to=cpaul@redhat.com \
--cc=andi@lisas.de \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox