Re: [PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch

Mark Brown
2015-07-16T20:55:45Z

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

On Thu, Jul 16, 2015 at 04:36:22PM +0100, Nariman Poushin wrote:

> +
> + if (regs[i].delay_us)
> + udelay(regs[i].delay_us);

This is a bit funky. While Takashi is correct that we could be running
in a spinlock equally this will mean that we could end up with some
really long busy waits. It feels like we should at least make an effort
to complain about that, print a warning or something.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]