From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756249AbbGPRwY (ORCPT ); Thu, 16 Jul 2015 13:52:24 -0400 Received: from smtprelay0246.hostedemail.com ([216.40.44.246]:59591 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755808AbbGPRwX (ORCPT ); Thu, 16 Jul 2015 13:52:23 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3873:3874:4321:5007:6261:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: boat67_147420b18cc2d X-Filterd-Recvd-Size: 1946 Message-ID: <1437069139.2495.12.camel@perches.com> Subject: Re: [PATCH] Staging: drivers: dgnc From: Joe Perches To: Craig Inches Cc: Craig Inches , lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 16 Jul 2015 10:52:19 -0700 In-Reply-To: <20150717002041.GA8792@Morat.xayto.local> References: <1437088293-12128-1-git-send-email-craig.inches@xayto.net> <1437060653.16262.25.camel@perches.com> <20150717002041.GA8792@Morat.xayto.local> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-07-17 at 00:20 +0000, Craig Inches wrote: > Hi Joe, Rehi Craig. > On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote: > > > Fixed up some checkpatch.pl style issues. > > > Line greater than 80 Chars in multiple locations. > > > > I think most all of these are not improvements. > Ok, can you be a little more specific? I did see some that where > not worth modifying due to only being 1 or 2 chars over, and > breaking the line seemed pointless. Precisely. Please don't do things you recognize as pointless just to satisfy some brainless script. > > Please use --strict when verifying your patches. > Not sure where the --strict should be set? I cant see the option > in the checklist.pl script $ ./scripts/checkpatch.pl --help [...] --subjective, --strict enable more subjective tests [...] $