From: Joe Perches <joe@perches.com>
To: Ahmed Mohamed Abd EL Mawgood <ahmedsoliman0x666@gmail.com>
Cc: james.l.morris@oracle.com, serge@hallyn.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Security.c: fix 3 coding style indentation errors
Date: Thu, 16 Jul 2015 11:38:11 -0700 [thread overview]
Message-ID: <1437071891.2495.26.camel@perches.com> (raw)
In-Reply-To: <1437063676.25587.5.camel@My-Computer>
On Thu, 2015-07-16 at 18:21 +0200, Ahmed Mohamed Abd EL Mawgood wrote:
> This is my first patch to get my hand dirty
> 3 simple indentation errors fixing withen security/security.c
[]
> diff --git a/security/security.c b/security/security.c
[]
> @@ -567,8 +567,8 @@ int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry,
> struct inode *new_dir, struct dentry *new_dentry,
> unsigned int flags)
> {
> - if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
> - (d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
> + if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
> + (d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
> return 0;
See Documentation/CodingStyle, chapter 2:
Descendents are "substantially to the right", not aligned to the if
Some prefer alignment to open parentheses like:
if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
(d_is_positive(new_dentry) &&
IS_PRIVATE(d_backing_inode(new_dentry)))))
Others just want the indentation on a tab stop.
prev parent reply other threads:[~2015-07-16 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 16:21 [PATCH] Security.c: fix 3 coding style indentation errors Ahmed Mohamed Abd EL Mawgood
2015-07-16 18:38 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437071891.2495.26.camel@perches.com \
--to=joe@perches.com \
--cc=ahmedsoliman0x666@gmail.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox