From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752603AbbGRAPu (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jul 2015 20:15:50 -0400
Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:53719 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751565AbbGRAPt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jul 2015 20:15:49 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3867:3874:4321:5007:6119:6261:6691:8957:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: class28_4f9bbed504804
X-Filterd-Recvd-Size: 1730
Message-ID: <1437178545.2495.105.camel@perches.com>
Subject: Re: [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style
 issues in r8192U_core.c
From: Joe Perches <joe@perches.com>
To: Joseph-Eugene Winzer <m999@openmailbox.org>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Fri, 17 Jul 2015 17:15:45 -0700
In-Reply-To: <1437141560-22517-5-git-send-email-m999@openmailbox.org>
References: <1437141560-22517-1-git-send-email-m999@openmailbox.org>
	 <1437141560-22517-5-git-send-email-m999@openmailbox.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
> Fixed a few lines that were longer than 80 chars.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
[]
> @@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8 channel_plan, struct r8192_priv *priv)
>  				    ChannelPlan[channel_plan].Channel[i] >
>  								max_chan)
>  					break;
> -				GET_DOT11D_INFO(ieee)->channel_map[ChannelPlan[channel_plan].Channel[i]] = 1;
> +				GET_DOT11D_INFO(ieee)->
> +					channel_map[ChannelPlan[channel_plan].
> +						Channel[i]] = 1;

That's _very_ not nice to read.

Try using more temporaries instead.

				index = ChannelPlan[channel_plan].Channel[i];
				GET_DOT11D_INFO(ieee)->channel_map[index] = 1;

etc...