From: Joe Perches <joe@perches.com>
To: Mario Bambagini <mario.bambagini@gmail.com>
Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fix to match 80-char rule
Date: Sun, 19 Jul 2015 12:28:01 -0700 [thread overview]
Message-ID: <1437334081.24289.21.camel@perches.com> (raw)
In-Reply-To: <1437331311-16973-1-git-send-email-mario.bambagini@gmail.com>
On Sun, 2015-07-19 at 20:41 +0200, Mario Bambagini wrote:
> Fixed comment line to match the 80-char rules.
> The line contained 81 characters.
> The file is fully compliant with the code style, now.
>
> Signed-off-by: Mario Bambagini <mario.bambagini@gmail.com>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> index e5cc5be..931e45e 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> @@ -24,7 +24,7 @@
> License along with this program; if not, write to the
> Free Software Foundation, Inc., 59 Temple Place -
> Suite 330, Boston, MA 02111-1307, USA.
> - -----------------------------------------------------------------------------*/
> + ----------------------------------------------------------------------------*/
Perhaps it'd be nicer to use the normal comment block style
/*
* <comment>
* <comment>
*/
Something like:
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 56 ++++++++++++------------
1 file changed, 29 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
index e5cc5be..fc7d19f 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
@@ -1,30 +1,32 @@
-/*---------------------------------------------------------------------------
- FT1000 driver for Flarion Flash OFDM NIC Device
-
- Copyright (C) 1999 David A. Hinds. All Rights Reserved.
- Copyright (C) 2002 Flarion Technologies, All rights reserved.
- Copyright (C) 2006 Patrik Ostrihon, All rights reserved.
- Copyright (C) 2006 ProWeb Consulting, a.s, All rights reserved.
-
- The initial developer of the original code is David A. Hinds
- <dahinds@users.sourceforge.net>. Portions created by David A. Hinds.
-
- This file was modified to support the Flarion Flash OFDM NIC Device
- by Wai Chan (w.chan@flarion.com).
-
- Port for kernel 2.6 created by Patrik Ostrihon (patrik.ostrihon@pwc.sk)
-
- This program is free software; you can redistribute it and/or modify it
- under the terms of the GNU General Public License as published by the Free
- Software Foundation; either version 2 of the License, or (at your option) any
- later version. This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
- or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- more details. You should have received a copy of the GNU General Public
- License along with this program; if not, write to the
- Free Software Foundation, Inc., 59 Temple Place -
- Suite 330, Boston, MA 02111-1307, USA.
- -----------------------------------------------------------------------------*/
+/*
+ * FT1000 driver for Flarion Flash OFDM NIC Device
+ *
+ * Copyright (C) 1999 David A. Hinds. All Rights Reserved.
+ * Copyright (C) 2002 Flarion Technologies, All rights reserved.
+ * Copyright (C) 2006 Patrik Ostrihon, All rights reserved.
+ * Copyright (C) 2006 ProWeb Consulting, a.s, All rights reserved.
+ *
+ * The initial developer of the original code is David A. Hinds
+ * <dahinds@users.sourceforge.net>. Portions created by David A. Hinds.
+ *
+ * This file was modified to support the Flarion Flash OFDM NIC Device
+ * by Wai Chan (w.chan@flarion.com).
+ *
+ * Port for kernel 2.6 created by Patrik Ostrihon (patrik.ostrihon@pwc.sk)
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
#include <linux/kernel.h>
#include <linux/module.h>
next prev parent reply other threads:[~2015-07-19 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 18:41 [PATCH] staging: fix to match 80-char rule Mario Bambagini
2015-07-19 19:28 ` Joe Perches [this message]
2015-07-20 20:09 ` Mario Bambagini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437334081.24289.21.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=mario.bambagini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox