From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754591AbbGST2I (ORCPT ); Sun, 19 Jul 2015 15:28:08 -0400 Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:53809 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754463AbbGST2F (ORCPT ); Sun, 19 Jul 2015 15:28:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:69:355:379:541:599:800:960:966:967:973:988:989:1042:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1535:1544:1593:1594:1605:1711:1730:1747:1777:1792:2196:2199:2376:2393:2525:2538:2539:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3855:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4385:4647:5007:6238:6261:6690:6755:7208:7514:7809:7903:8599:8957:9025:9388:9592:9855:10004:10049:10848:10920:11232:11657:11658:11914:12043:12219:12517:12519:12555:12683:12707:12737:12740:13437:14096:14097:14345:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: nose44_c06ac189b400 X-Filterd-Recvd-Size: 5348 Message-ID: <1437334081.24289.21.camel@perches.com> Subject: Re: [PATCH] staging: fix to match 80-char rule From: Joe Perches To: Mario Bambagini Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 19 Jul 2015 12:28:01 -0700 In-Reply-To: <1437331311-16973-1-git-send-email-mario.bambagini@gmail.com> References: <1437331311-16973-1-git-send-email-mario.bambagini@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-07-19 at 20:41 +0200, Mario Bambagini wrote: > Fixed comment line to match the 80-char rules. > The line contained 81 characters. > The file is fully compliant with the code style, now. > > Signed-off-by: Mario Bambagini > --- > drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c > index e5cc5be..931e45e 100644 > --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c > +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c > @@ -24,7 +24,7 @@ > License along with this program; if not, write to the > Free Software Foundation, Inc., 59 Temple Place - > Suite 330, Boston, MA 02111-1307, USA. > - -----------------------------------------------------------------------------*/ > + ----------------------------------------------------------------------------*/ Perhaps it'd be nicer to use the normal comment block style /* * * */ Something like: --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 56 ++++++++++++------------ 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c index e5cc5be..fc7d19f 100644 --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c @@ -1,30 +1,32 @@ -/*--------------------------------------------------------------------------- - FT1000 driver for Flarion Flash OFDM NIC Device - - Copyright (C) 1999 David A. Hinds. All Rights Reserved. - Copyright (C) 2002 Flarion Technologies, All rights reserved. - Copyright (C) 2006 Patrik Ostrihon, All rights reserved. - Copyright (C) 2006 ProWeb Consulting, a.s, All rights reserved. - - The initial developer of the original code is David A. Hinds - . Portions created by David A. Hinds. - - This file was modified to support the Flarion Flash OFDM NIC Device - by Wai Chan (w.chan@flarion.com). - - Port for kernel 2.6 created by Patrik Ostrihon (patrik.ostrihon@pwc.sk) - - This program is free software; you can redistribute it and/or modify it - under the terms of the GNU General Public License as published by the Free - Software Foundation; either version 2 of the License, or (at your option) any - later version. This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY - or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - more details. You should have received a copy of the GNU General Public - License along with this program; if not, write to the - Free Software Foundation, Inc., 59 Temple Place - - Suite 330, Boston, MA 02111-1307, USA. - -----------------------------------------------------------------------------*/ +/* + * FT1000 driver for Flarion Flash OFDM NIC Device + * + * Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * Copyright (C) 2002 Flarion Technologies, All rights reserved. + * Copyright (C) 2006 Patrik Ostrihon, All rights reserved. + * Copyright (C) 2006 ProWeb Consulting, a.s, All rights reserved. + * + * The initial developer of the original code is David A. Hinds + * . Portions created by David A. Hinds. + * + * This file was modified to support the Flarion Flash OFDM NIC Device + * by Wai Chan (w.chan@flarion.com). + * + * Port for kernel 2.6 created by Patrik Ostrihon (patrik.ostrihon@pwc.sk) + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your + * option) any later version. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see . + */ #include #include