From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 2/4] auxdisplay: ks0108: start using pr_*
Date: Mon, 20 Jul 2015 17:27:22 +0530 [thread overview]
Message-ID: <1437393444-32035-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1437393444-32035-1-git-send-email-sudipm.mukherjee@gmail.com>
Start using pr_* macros instead of using printk and in the process
define pr_fmt.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/auxdisplay/ks0108.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c
index 0d75285..30d6d0e 100644
--- a/drivers/auxdisplay/ks0108.c
+++ b/drivers/auxdisplay/ks0108.c
@@ -23,6 +23,8 @@
*
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/init.h>
#include <linux/module.h>
#include <linux/kernel.h>
@@ -132,8 +134,7 @@ static int __init ks0108_init(void)
ks0108_parport = parport_find_base(ks0108_port);
if (ks0108_parport == NULL) {
- printk(KERN_ERR KS0108_NAME ": ERROR: "
- "parport didn't find %i port\n", ks0108_port);
+ pr_err("ERROR: parport didn't find %i port\n", ks0108_port);
goto none;
}
@@ -141,15 +142,14 @@ static int __init ks0108_init(void)
NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);
parport_put_port(ks0108_parport);
if (ks0108_pardevice == NULL) {
- printk(KERN_ERR KS0108_NAME ": ERROR: "
- "parport didn't register new device\n");
+ pr_err("ERROR: parport didn't register new device\n");
goto none;
}
result = parport_claim(ks0108_pardevice);
if (result != 0) {
- printk(KERN_ERR KS0108_NAME ": ERROR: "
- "can't claim %i parport, maybe in use\n", ks0108_port);
+ pr_err("ERROR: can't claim %i parport, maybe in use\n",
+ ks0108_port);
ret = result;
goto registered;
}
--
1.8.1.2
next prev parent reply other threads:[~2015-07-20 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 11:57 [PATCH 1/4] auxdisplay: ks0108: fix refcount Sudip Mukherjee
2015-07-20 11:57 ` Sudip Mukherjee [this message]
2015-07-20 11:57 ` [PATCH 3/4] auxdisplay: ks0108: use min_t Sudip Mukherjee
2015-07-20 11:57 ` [PATCH 4/4] auxdisplay: ks0108: use new parport device model Sudip Mukherjee
2015-07-29 6:53 ` [PATCH 1/4] auxdisplay: ks0108: fix refcount Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437393444-32035-2-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).