From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 4/4] auxdisplay: ks0108: use new parport device model
Date: Mon, 20 Jul 2015 17:27:24 +0530 [thread overview]
Message-ID: <1437393444-32035-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1437393444-32035-1-git-send-email-sudipm.mukherjee@gmail.com>
Modify auxdisplay driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/auxdisplay/ks0108.c | 76 ++++++++++++++++++++++++++++-----------------
1 file changed, 47 insertions(+), 29 deletions(-)
diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c
index ce00e95..b58de31 100644
--- a/drivers/auxdisplay/ks0108.c
+++ b/drivers/auxdisplay/ks0108.c
@@ -125,51 +125,69 @@ unsigned char ks0108_isinited(void)
}
EXPORT_SYMBOL_GPL(ks0108_isinited);
-/*
- * Module Init & Exit
- */
-
-static int __init ks0108_init(void)
+static void ks0108_parport_attach(struct parport *port)
{
- int result;
- int ret = -EINVAL;
+ struct pardev_cb ks0108_cb;
- ks0108_parport = parport_find_base(ks0108_port);
- if (ks0108_parport == NULL) {
- pr_err("ERROR: parport didn't find %i port\n", ks0108_port);
- goto none;
- }
+ if (port->base != ks0108_port)
+ return;
- ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME,
- NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);
- parport_put_port(ks0108_parport);
- if (ks0108_pardevice == NULL) {
+ memset(&ks0108_cb, 0, sizeof(ks0108_cb));
+ ks0108_cb.flags = PARPORT_DEV_EXCL;
+ ks0108_pardevice = parport_register_dev_model(port, KS0108_NAME,
+ &ks0108_cb, 0);
+ if (!ks0108_pardevice) {
pr_err("ERROR: parport didn't register new device\n");
- goto none;
+ return;
}
-
- result = parport_claim(ks0108_pardevice);
- if (result != 0) {
- pr_err("ERROR: can't claim %i parport, maybe in use\n",
+ if (parport_claim(ks0108_pardevice)) {
+ pr_err("could not claim access to parport %i. Aborting.\n",
ks0108_port);
- ret = result;
- goto registered;
+ goto err_unreg_device;
}
ks0108_inited = 1;
- return 0;
+ return;
-registered:
+err_unreg_device:
parport_unregister_device(ks0108_pardevice);
-
-none:
- return ret;
+ ks0108_pardevice = NULL;
}
-static void __exit ks0108_exit(void)
+static void ks0108_parport_detach(struct parport *port)
{
+ if (port->base != ks0108_port)
+ return;
+
+ if (!ks0108_pardevice) {
+ pr_err("%s: already unregistered.\n", KS0108_NAME);
+ return;
+ }
+
parport_release(ks0108_pardevice);
parport_unregister_device(ks0108_pardevice);
+ ks0108_pardevice = NULL;
+}
+
+/*
+ * Module Init & Exit
+ */
+
+static struct parport_driver ks0108_parport_driver = {
+ .name = "ks0108",
+ .match_port = ks0108_parport_attach,
+ .detach = ks0108_parport_detach,
+ .devmodel = true,
+};
+
+static int __init ks0108_init(void)
+{
+ return parport_register_driver(&ks0108_parport_driver);
+}
+
+static void __exit ks0108_exit(void)
+{
+ parport_unregister_driver(&ks0108_parport_driver);
}
module_init(ks0108_init);
--
1.8.1.2
next prev parent reply other threads:[~2015-07-20 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 11:57 [PATCH 1/4] auxdisplay: ks0108: fix refcount Sudip Mukherjee
2015-07-20 11:57 ` [PATCH 2/4] auxdisplay: ks0108: start using pr_* Sudip Mukherjee
2015-07-20 11:57 ` [PATCH 3/4] auxdisplay: ks0108: use min_t Sudip Mukherjee
2015-07-20 11:57 ` Sudip Mukherjee [this message]
2015-07-29 6:53 ` [PATCH 1/4] auxdisplay: ks0108: fix refcount Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437393444-32035-4-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).