From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757543AbbGUAsr (ORCPT ); Mon, 20 Jul 2015 20:48:47 -0400 Received: from smtprelay0077.hostedemail.com ([216.40.44.77]:60420 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756847AbbGUAsp (ORCPT ); Mon, 20 Jul 2015 20:48:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2895:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:5007:6261:6742:7903:8957:10004:10400:10848:11232:11658:11914:12043:12295:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: snow64_6912df318e70e X-Filterd-Recvd-Size: 2103 Message-ID: <1437439720.28284.4.camel@perches.com> Subject: Re: [PATCH tip/core/rcu 15/16] scripts: Make checkpatch.pl warn on expedited RCU grace periods From: Joe Perches To: paulmck@linux.vnet.ibm.com Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, Andy Whitcroft Date: Mon, 20 Jul 2015 17:48:40 -0700 In-Reply-To: <20150721004104.GN3717@linux.vnet.ibm.com> References: <20150717221949.GA12304@linux.vnet.ibm.com> <1437171616-13832-1-git-send-email-paulmck@linux.vnet.ibm.com> <1437171616-13832-15-git-send-email-paulmck@linux.vnet.ibm.com> <1437172674.2495.60.camel@perches.com> <20150721004104.GN3717@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-07-20 at 17:41 -0700, Paul E. McKenney wrote: > On Fri, Jul 17, 2015 at 03:37:54PM -0700, Joe Perches wrote: > > It'd be faster perl without capture groups: > > > > if ($line =~ /\b(?:synchronize_(?:rcu|sched)_expedited)\s*\(/) { > > Fair enough, but this pattern is used rather heavily in this script, > and I don't trust my perl enough to want to create a new pattern. > > I see a couple of possible ways forward: > > 1. I hand this patch off to you, and you update it as you deem fit. > > 2. I push the patch as is (after the fix below) and you update > checkpatch as a whole to use the more efficient code. > > How would you like to proceed? Push and fix would work fine.