Re: [PATCH 02/47] perf stat: Introduce struct perf_stat_config

Arnaldo Carvalho de Melo
2015-07-21T17:37:34Z

Em Tue, Jul 21, 2015 at 02:24:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Jul 21, 2015 at 02:31:22PM +0200, Jiri Olsa escreveu:
> > Moving aggr_mode into new struct. The point is to centralize
> > the base stat config so it could be used localy together with
> > other stat routines in other parts of perf code.
>
> Why not use 'struct perf_stat' for that? It is already there and is
> supposed to hold the stat tool internal state. Yeah, lots of those
> globals should go there as well, just like we have the 'perf_sched',
> 'perf_top', 'perf_script',y etc structs.

Erm, saw some more patches, this stuff gets marshalled into perf.data,
continuing to read... Probably you made this somehow extensible...

- Arnaldo