Re: [PATCH 02/47] perf stat: Introduce struct perf_stat_config

Jiri Olsa
2015-07-22T08:39:40Z

On Tue, Jul 21, 2015 at 02:37:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 21, 2015 at 02:24:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Jul 21, 2015 at 02:31:22PM +0200, Jiri Olsa escreveu:
> > > Moving aggr_mode into new struct. The point is to centralize
> > > the base stat config so it could be used localy together with
> > > other stat routines in other parts of perf code.
> >
> > Why not use 'struct perf_stat' for that? It is already there and is
> > supposed to hold the stat tool internal state. Yeah, lots of those
> > globals should go there as well, just like we have the 'perf_sched',
> > 'perf_top', 'perf_script',y etc structs.

hm, but it's used as perf_evsel priv data..

the 'struct perf_stat_config' is coupled with the same event,
we could switch the name for:

'struct perf_stat' -> 'struct perf_evsel_stat'
'struct perf_stat_cmd' -> 'struct perf_stat'

and move 'struct perf_stat_record' under 'struct perf_stat' ;-)

>
> Erm, saw some more patches, this stuff gets marshalled into perf.data,
> continuing to read... Probably you made this somehow extensible...

yep, I'm storing it in 'tag-value' way, it's mentioned in the changelog

jirka