public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	jbeulich@suse.com, hpa@zytor.com, peterz@infradead.org,
	mingo@kernel.org, bp@suse.de, luto@amacapital.net,
	torvalds@linux-foundation.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/mm/pat: Adjust default caching mode translation tables
Date: Wed, 22 Jul 2015 09:09:36 -0600	[thread overview]
Message-ID: <1437577776.3214.252.camel@hp.com> (raw)
In-Reply-To: <tip-ca1fec58bc6a90be96a59b4769e951156846c6ca@git.kernel.org>

Ingo,

Please drop this change as I explained below.
http://marc.info/?l=linux-kernel&m=143751782107284&w=2

Thanks,
-Toshi


On Tue, 2015-07-21 at 02:38 -0700, tip-bot for Jan Beulich wrote:
> Commit-ID:  ca1fec58bc6a90be96a59b4769e951156846c6ca
> Gitweb:     
> http://git.kernel.org/tip/ca1fec58bc6a90be96a59b4769e951156846c6ca
> Author:     Jan Beulich <JBeulich@suse.com>
> AuthorDate: Mon, 20 Jul 2015 08:46:14 +0100
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 21 Jul 2015 08:23:06 +0200
> 
> x86/mm/pat: Adjust default caching mode translation tables
> 
> Make WT really mean WT (rather than UC).
> 
> I can't see why commit 9cd25aac1f ("x86/mm/pat: Emulate PAT when
> it is disabled") didn't make this to match its changes to
> pat_init().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Toshi Kani <toshi.kani@hp.com>
> Link: 
> http://lkml.kernel.org/r/55ACC3660200007800092E62@mail.emea.novell.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  arch/x86/mm/init.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index 8533b46..7a45322 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -43,18 +43,18 @@ uint16_t __cachemode2pte_tbl[_PAGE_CACHE_MODE_NUM] = 
> {
>  	[_PAGE_CACHE_MODE_WC      ]	= 0         | _PAGE_PCD,
>  	[_PAGE_CACHE_MODE_UC_MINUS]	= 0         | _PAGE_PCD,
>  	[_PAGE_CACHE_MODE_UC      ]	= _PAGE_PWT | _PAGE_PCD,
> -	[_PAGE_CACHE_MODE_WT      ]	= 0         | _PAGE_PCD,
> +	[_PAGE_CACHE_MODE_WT      ]	= _PAGE_PWT | 0,
>  	[_PAGE_CACHE_MODE_WP      ]	= 0         | _PAGE_PCD,
>  };
>  EXPORT_SYMBOL(__cachemode2pte_tbl);
>  
>  uint8_t __pte2cachemode_tbl[8] = {
>  	[__pte2cm_idx( 0        | 0         | 0        )] = 
> _PAGE_CACHE_MODE_WB,
> -	[__pte2cm_idx(_PAGE_PWT | 0         | 0        )] = 
> _PAGE_CACHE_MODE_UC_MINUS,
> +	[__pte2cm_idx(_PAGE_PWT | 0         | 0        )] = 
> _PAGE_CACHE_MODE_WT,
>  	[__pte2cm_idx( 0        | _PAGE_PCD | 0        )] = 
> _PAGE_CACHE_MODE_UC_MINUS,
>  	[__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | 0        )] = 
> _PAGE_CACHE_MODE_UC,
>  	[__pte2cm_idx( 0        | 0         | _PAGE_PAT)] = 
> _PAGE_CACHE_MODE_WB,
> -	[__pte2cm_idx(_PAGE_PWT | 0         | _PAGE_PAT)] = 
> _PAGE_CACHE_MODE_UC_MINUS,
> +	[__pte2cm_idx(_PAGE_PWT | 0         | _PAGE_PAT)] = 
> _PAGE_CACHE_MODE_WT,
>  	[__pte2cm_idx(0         | _PAGE_PCD | _PAGE_PAT)] = 
> _PAGE_CACHE_MODE_UC_MINUS,
>  	[__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | _PAGE_PAT)] = 
> _PAGE_CACHE_MODE_UC,
>  };

  reply	other threads:[~2015-07-22 15:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20  7:46 [PATCH] x86: adjust default caching mode translation tables Jan Beulich
2015-07-21  9:38 ` [tip:x86/urgent] x86/mm/pat: Adjust " tip-bot for Jan Beulich
2015-07-22 15:09   ` Toshi Kani [this message]
2015-07-26  8:33     ` [tip:x86/urgent] x86/mm/pat: Revert ' Adjust default caching mode translation tables' tip-bot for Thomas Gleixner
2015-07-21 22:29 ` [PATCH] x86: adjust default caching mode translation tables Toshi Kani
2015-07-22 15:17   ` Jan Beulich
2015-07-22 15:23     ` Toshi Kani
2015-07-22 15:41       ` Jan Beulich
2015-07-22 16:06         ` Toshi Kani
2015-07-22 16:36           ` Jan Beulich
2015-07-22 16:48             ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437577776.3214.252.camel@hp.com \
    --to=toshi.kani@hp.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jbeulich@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox