RE: [PATCH net 1/2] r8152: add pre_reset and post_reset

Hayes Wang
2015-07-28T10:29:22Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 854 bytes --]

Oliver Neukum [mailto:oneukum@suse.com]
> Sent: Tuesday, July 28, 2015 4:53 PM
[...]
> > + return 0;
> > +
> > + netdev = tp->netdev;
> > + if (!netif_running(netdev))
> > + return 0;
> > +
> > + ret = usb_autopm_get_interface(intf);
> > + if (ret < 0)
> > + return ret;
>
> What sense does this make?
>
[...]
> > + return 0;
> > +
> > + netdev = tp->netdev;
> > + if (!netif_running(netdev))
> > + return 0;
> > +
> > + ret = usb_autopm_get_interface(intf);
>
> The device will be awake.

I don't sure if the device would be in runtimesuspend, so I wake it up by myself.
I think you mean I don't have to do this. I would remove them and resend the
patch. Thanks.

Best Regards,
Hayes

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥