From: Pawel Moll <pawel.moll@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tests: Adding build test for having ending slash in double slash
Date: Tue, 28 Jul 2015 14:44:32 +0100 [thread overview]
Message-ID: <1438091072.2114.24.camel@arm.com> (raw)
In-Reply-To: <1438087252.2114.15.camel@arm.com>
On Tue, 2015-07-28 at 13:40 +0100, Pawel Moll wrote:
> Interesting. Building from a perf-tar-src-pkg tarball works:
>
> $ rm -rf /tmp/krava/ && make install prefix=/tmp/krava
> [...]
> LINK perf
> LINK libperf-gtk.so
> INSTALL GTK UI
> INSTALL binaries
> INSTALL tests
> INSTALL libexec
> INSTALL perf-archive
> INSTALL perf-with-kcore
> INSTALL perl-scripts
> INSTALL python-scripts
> INSTALL perf_completion-script
>
> but it breaks indeed the way you pointed out when building in-tree...
Ignore what I said above. The real issue is that $(realpath PATH)
returns nothing if PATH does not actually exist. Didn't know that...
Will send v2 soon.
Pawel
next prev parent reply other threads:[~2015-07-28 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 16:46 [PATCH] tools: perf: Fix test build error when bindir contains double slash Pawel Moll
2015-07-27 18:24 ` [PATCH] perf tests: Adding build test for having ending slash in " Jiri Olsa
2015-07-28 12:40 ` Pawel Moll
2015-07-28 13:44 ` Pawel Moll [this message]
2015-07-31 13:55 ` [tip:perf/core] perf tests: Adding build test for having ending " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438091072.2114.24.camel@arm.com \
--to=pawel.moll@arm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox