From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, eranian@google.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 1/4] perf, tools: Do not include escape sequences in color_vfprintf return
Date: Wed, 29 Jul 2015 17:21:37 -0700 [thread overview]
Message-ID: <1438215700-5530-2-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1438215700-5530-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
color_vprintf was including the length of the invisible escape
sequences in its return argument. Don't include them to make
the return value usable for indentation calculations.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/color.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c
index 55355b3..f3d1d6d 100644
--- a/tools/perf/util/color.c
+++ b/tools/perf/util/color.c
@@ -83,12 +83,12 @@ static int __color_vfprintf(FILE *fp, const char *color, const char *fmt,
}
if (perf_use_color_default && *color)
- r += fprintf(fp, "%s", color);
+ fprintf(fp, "%s", color);
r += vfprintf(fp, fmt, args);
if (perf_use_color_default && *color)
- r += fprintf(fp, "%s", PERF_COLOR_RESET);
+ fprintf(fp, "%s", PERF_COLOR_RESET);
if (trail)
- r += fprintf(fp, "%s", trail);
+ fprintf(fp, "%s", trail);
return r;
}
--
2.4.3
next prev parent reply other threads:[~2015-07-30 0:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:21 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2015-07-30 0:21 ` Andi Kleen [this message]
2015-07-30 12:35 ` [PATCH] perf tools: Remove color_fprintf_ln function Jiri Olsa
2015-07-30 0:21 ` [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-07-30 13:42 ` Jiri Olsa
2015-07-30 13:47 ` Jiri Olsa
2015-08-04 0:41 ` Andi Kleen
2015-08-08 17:40 ` Jiri Olsa
2015-07-30 0:21 ` [PATCH 3/4] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-07-30 13:53 ` Jiri Olsa
2015-07-30 0:21 ` [PATCH 4/4] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-07-30 14:06 ` Jiri Olsa
2015-07-30 14:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438215700-5530-2-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox