From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbbG3MKw (ORCPT ); Thu, 30 Jul 2015 08:10:52 -0400 Received: from smtprelay0066.hostedemail.com ([216.40.44.66]:57333 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751111AbbG3MKu (ORCPT ); Thu, 30 Jul 2015 08:10:50 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3872:4321:4605:5007:6261:7875:10004:10400:10848:11026:11232:11658:11914:12296:12438:12517:12519:12555:12740:13069:13311:13357:21063:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: son55_241141bb42817 X-Filterd-Recvd-Size: 2114 Message-ID: <1438258246.2677.17.camel@perches.com> Subject: Re: [PATCH] printk: Warn about dropped messages also on extended consoles From: Joe Perches To: Petr Mladek Cc: akpm@linux-foundation.org, Tejun Heo , davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Thu, 30 Jul 2015 05:10:46 -0700 In-Reply-To: <1438255732-31326-1-git-send-email-pmladek@suse.com> References: <1438255732-31326-1-git-send-email-pmladek@suse.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-07-30 at 13:28 +0200, Petr Mladek wrote: > The commit #6fe29354befe4c ("printk: implement support for extended console > drivers") added an extra buffer to format messages for extended consoles. > We need to put there also the warning about dropped messages, so it appears > on these consoles. [] > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c [] > @@ -2254,8 +2254,15 @@ again: > } > > if (console_seq < log_first_seq) { > - len = sprintf(text, "** %u printk messages dropped ** ", > - (unsigned)(log_first_seq - console_seq)); > + static const char dropped_msg[] = > + "** %u printk messages dropped ** "; I don't see any value in dropped_msg as a const char array instead of just using it directly as a format in sprintf. The linker will still use a single format string in any case. memcpy might be faster. if (nr_ext_console_drivers) memcpy(ext_text, text, len + 1); > + unsigned int dropped_count = > + (unsigned int)(log_first_seq - console_seq); > + > + len = sprintf(text, dropped_msg, dropped_count); > + if (nr_ext_console_drivers) > + ext_len = sprintf(ext_text, dropped_msg, > + dropped_count); >