Re: [PATCH v2 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA FMan support to the SoC device tree(s)

Re: [PATCH v2 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA FMan support to the SoC device tree(s)

[Scott Wood]

On Thu, 2015-07-30 at 07:33 +0300, Igal.Liberman wrote:
> @@ -307,4 +307,117 @@
>               reg = <0xe0000 0x1000>;
>               fsl,has-rstcr;
>       };
> +
> +      fman@100000{
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             cell-index = <0>;
> +             ranges = <0 0x100000 0x100000>;
> +             compatible = "fsl,fman";
> +             reg = <0x100000 0x100000>;
> +             interrupts = <24 2 0 0>, <16 2 1 30>;
> +             clock-frequency = <0>;
> +             fsl,qman-channel-range = <0x40 0x7>;

fman is supposed to have clocks/clock-names, not clock-frequency.

-Scott

RE: [PATCH v2 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA FMan support to the SoC device tree(s)

[Liberman Igal]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1394 bytes --]



Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, July 30, 2015 11:12 PM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Bucur
> Madalin-Cristian-B32716; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA FMan
> support to the SoC device tree(s)
> 
> On Thu, 2015-07-30 at 07:33 +0300, Igal.Liberman wrote:
> > @@ -307,4 +307,117 @@
> >               reg = <0xe0000 0x1000>;
> >               fsl,has-rstcr;
> >       };
> > +
> > +      fman@100000{
> > +             #address-cells = <1>;
> > +             #size-cells = <1>;
> > +             cell-index = <0>;
> > +             ranges = <0 0x100000 0x100000>;
> > +             compatible = "fsl,fman";
> > +             reg = <0x100000 0x100000>;
> > +             interrupts = <24 2 0 0>, <16 2 1 30>;
> > +             clock-frequency = <0>;
> > +             fsl,qman-channel-range = <0x40 0x7>;
> 
> fman is supposed to have clocks/clock-names, not clock-frequency.
> 

The new clock binding doesn't support P1023 yet. 
I'll drop P1023 from this submission, it's not supported currently by the driver, we'll re-add it later. 

> -Scott

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥