From: <b29983@freescale.com>
To: <b07421@freescale.com>
Cc: <linux-kernel@vger.kernel.org>,
Tang Yuantian <Yuantian.Tang@freescale.com>,
Chenhui Zhao <chenhui.zhao@freescale.com>,
Tang Yuantian <Yuantian.Tang@feescale.com>
Subject: [PATCH 3/3] PowerPC/mpc85xx: Add hotplug support on E6500 cores
Date: Fri, 31 Jul 2015 17:20:44 +0800 [thread overview]
Message-ID: <1438334444-31919-3-git-send-email-b29983@freescale.com> (raw)
In-Reply-To: <1438334444-31919-1-git-send-email-b29983@freescale.com>
From: Tang Yuantian <Yuantian.Tang@freescale.com>
Freescale E6500 core-based platforms, like t4240, support
disabling/enabling CPU dynamically.
This patch adds this feature on those platforms.
Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
Signed-off-by: Tang Yuantian <Yuantian.Tang@feescale.com>
---
arch/powerpc/include/asm/smp.h | 1 +
arch/powerpc/kernel/head_64.S | 10 +++++--
arch/powerpc/platforms/85xx/smp.c | 63 ++++++++++++++++++++++++++-------------
3 files changed, 52 insertions(+), 22 deletions(-)
diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h
index bf37d17..c7bd27d 100644
--- a/arch/powerpc/include/asm/smp.h
+++ b/arch/powerpc/include/asm/smp.h
@@ -198,6 +198,7 @@ extern void generic_secondary_thread_init(void);
extern unsigned long __secondary_hold_spinloop;
extern unsigned long __secondary_hold_acknowledge;
extern char __secondary_hold;
+extern unsigned int booting_cpu_hwid;
extern void __early_start(void);
#endif /* __ASSEMBLY__ */
diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S
index d48125d..c47544d 100644
--- a/arch/powerpc/kernel/head_64.S
+++ b/arch/powerpc/kernel/head_64.S
@@ -181,6 +181,10 @@ exception_marker:
#endif
#ifdef CONFIG_PPC_BOOK3E
+ .globl booting_cpu_hwid
+booting_cpu_hwid:
+ .long 0x0
+ .align 3
_GLOBAL(fsl_secondary_thread_init)
/* Enable branch prediction */
lis r3,BUCSR_INIT@h
@@ -197,8 +201,10 @@ _GLOBAL(fsl_secondary_thread_init)
* but the low bit right by two bits so that the cpu numbering is
* continuous.
*/
- mfspr r3, SPRN_PIR
- rlwimi r3, r3, 30, 2, 30
+ bl 10f
+10: mflr r22
+ addi r22,r22,(booting_cpu_hwid - 10b)
+ lwz r3,0(r22)
mtspr SPRN_PIR, r3
#endif
diff --git a/arch/powerpc/platforms/85xx/smp.c b/arch/powerpc/platforms/85xx/smp.c
index 7f0dadb..8652a49 100644
--- a/arch/powerpc/platforms/85xx/smp.c
+++ b/arch/powerpc/platforms/85xx/smp.c
@@ -189,15 +189,22 @@ static inline u32 read_spin_table_addr_l(void *spin_table)
static void wake_hw_thread(void *info)
{
void fsl_secondary_thread_init(void);
- unsigned long imsr1, inia1;
+ unsigned long imsr, inia;
int nr = *(const int *)info;
-
- imsr1 = MSR_KERNEL;
- inia1 = *(unsigned long *)fsl_secondary_thread_init;
-
- mttmr(TMRN_IMSR1, imsr1);
- mttmr(TMRN_INIA1, inia1);
- mtspr(SPRN_TENS, TEN_THREAD(1));
+ int hw_cpu = get_hard_smp_processor_id(nr);
+ int thread_idx = cpu_thread_in_core(hw_cpu);
+
+ booting_cpu_hwid = (u32)hw_cpu;
+ imsr = MSR_KERNEL;
+ inia = *(unsigned long *)fsl_secondary_thread_init;
+ if (thread_idx == 0) {
+ mttmr(TMRN_IMSR0, imsr);
+ mttmr(TMRN_INIA0, inia);
+ } else {
+ mttmr(TMRN_IMSR1, imsr);
+ mttmr(TMRN_INIA1, inia);
+ }
+ mtspr(SPRN_TENS, TEN_THREAD(thread_idx));
smp_generic_kick_cpu(nr);
}
@@ -219,27 +226,43 @@ static int smp_85xx_kick_cpu(int nr)
pr_debug("smp_85xx_kick_cpu: kick CPU #%d\n", nr);
#ifdef CONFIG_PPC64
- /* Threads don't use the spin table */
- if (cpu_thread_in_core(nr) != 0) {
+ if (threads_per_core > 1) {
int primary = cpu_first_thread_sibling(nr);
if (WARN_ON_ONCE(!cpu_has_feature(CPU_FTR_SMT)))
return -ENOENT;
- if (cpu_thread_in_core(nr) != 1) {
- pr_err("%s: cpu %d: invalid hw thread %d\n",
- __func__, nr, cpu_thread_in_core(nr));
- return -ENOENT;
+ /*
+ * If either one of threads in the same core is online,
+ * use the online one to start the other.
+ */
+ if (cpu_online(primary) || cpu_online(primary + 1)) {
+ qoriq_pm_ops->cpu_up(nr);
+ if (cpu_online(primary))
+ smp_call_function_single(primary,
+ wake_hw_thread, &nr, 1);
+ else
+ smp_call_function_single(primary + 1,
+ wake_hw_thread, &nr, 1);
+ return 0;
}
- if (!cpu_online(primary)) {
- pr_err("%s: cpu %d: primary %d not online\n",
- __func__, nr, primary);
- return -ENOENT;
+ /*
+ * If both threads are offline, reset core to start.
+ * When core is up, Thread 0 always gets up first,
+ * so bind the current logical cpu with Thread 0.
+ */
+ if (hw_cpu != cpu_first_thread_sibling(hw_cpu)) {
+ int hw_cpu1, hw_cpu2;
+
+ hw_cpu1 = get_hard_smp_processor_id(primary);
+ hw_cpu2 = get_hard_smp_processor_id(primary + 1);
+ set_hard_smp_processor_id(primary, hw_cpu2);
+ set_hard_smp_processor_id(primary + 1, hw_cpu1);
+ /* get new physical cpu id */
+ hw_cpu = get_hard_smp_processor_id(nr);
}
- smp_call_function_single(primary, wake_hw_thread, &nr, 0);
- return 0;
}
#endif
--
2.1.0.27.g96db324
next prev parent reply other threads:[~2015-07-31 9:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 9:20 [PATCH 1/3] Powerpc: mpc85xx: refactor the PM operations b29983
2015-07-31 9:20 ` [PATCH 2/3] PowerPC/mpc85xx: Add hotplug support on E5500 and E500MC cores b29983
2015-08-01 0:14 ` Scott Wood
2015-08-03 11:52 ` Chenhui Zhao
2015-08-03 21:18 ` Scott Wood
2015-08-05 10:39 ` Chenhui Zhao
2015-07-31 9:20 ` b29983 [this message]
2015-08-01 0:22 ` [PATCH 3/3] PowerPC/mpc85xx: Add hotplug support on E6500 cores Scott Wood
2015-08-05 11:08 ` Chenhui Zhao
2015-08-06 3:16 ` Scott Wood
2015-08-06 4:32 ` Chenhui Zhao
2015-08-06 5:44 ` Scott Wood
2015-07-31 23:59 ` [PATCH 1/3] Powerpc: mpc85xx: refactor the PM operations Scott Wood
2015-08-03 11:32 ` Chenhui Zhao
2015-08-03 20:26 ` Scott Wood
2015-08-05 10:11 ` Chenhui Zhao
2015-08-06 2:57 ` Scott Wood
2015-08-06 4:20 ` Chenhui Zhao
2015-08-06 5:46 ` Scott Wood
2015-08-06 5:54 ` Chenhui Zhao
2015-08-06 18:02 ` Scott Wood
2015-08-07 3:19 ` Chenhui Zhao
2015-08-08 0:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438334444-31919-3-git-send-email-b29983@freescale.com \
--to=b29983@freescale.com \
--cc=Yuantian.Tang@feescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=b07421@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).