From: Joe Perches <joe@perches.com>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: Don Brace <don.brace@pmcs.com>,
linux-kernel@vger.kernel.org, iss_storagedev@hp.com,
storagedev@pmcs.com, linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>
Date: Mon, 03 Aug 2015 01:03:46 -0700 [thread overview]
Message-ID: <1438589026.30149.15.camel@perches.com> (raw)
In-Reply-To: <9547AF94-2168-4987-AD89-B7F111084CC2@gmail.com>
On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote:
> > On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote:
> >
> > Correct misuse of 0x%d in logging messages.
> >
[]
> why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding
> commands = %#x\n” ?
> %#x will add 0x prefix automatically .
It's generally a consistency thing.
A 0 value would be emitted as 0 and not 0x0.
next prev parent reply other threads:[~2015-08-03 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 20:25 [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> Joe Perches
2015-08-03 7:20 ` Johannes Thumshirn
2015-08-03 7:25 ` yalin wang
2015-08-03 8:03 ` Joe Perches [this message]
2015-08-03 8:56 ` yalin wang
2015-08-04 2:19 ` yalin wang
2015-08-04 2:27 ` Joe Perches
2015-08-04 4:04 ` yalin wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438589026.30149.15.camel@perches.com \
--to=joe@perches.com \
--cc=don.brace@pmcs.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=storagedev@pmcs.com \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox