From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"tinajohnson.1234@gmail.com" <tinajohnson.1234@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"fabio.falzoi84@gmail.com" <fabio.falzoi84@gmail.com>,
"roxanagabriela10@gmail.com" <roxanagabriela10@gmail.com>,
"vatikaharlalka@gmail.com" <vatikaharlalka@gmail.com>,
"Shah, Yash (Y.)" <yshah1@visteon.com>,
"contact@timothyleung.co" <contact@timothyleung.co>
Subject: Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl
Date: Mon, 03 Aug 2015 05:18:17 -0700 [thread overview]
Message-ID: <1438604297.30149.29.camel@perches.com> (raw)
In-Reply-To: <20150803120945.GX5180@mwanda>
On Mon, 2015-08-03 at 15:09 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote:
> > > > From: Yash Shah <yshah1@visteon.com>
> > > >
> > > > Fixed code indentation warning as detected by checkpatch.pl.
> > > >
> > > > Signed-off-by: Yash Shah <yshah1@visteon.com>
> > >
> > > Defines aren't allowed in .c files anyway.
> >
> > The kernel source tree disagrees with you
> >
> > $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l
> > 175830
>
> Duh. Sorry. I meant ifdefs. I'm sure you can find lots of examples
> of those too,
Yeah, no worries, only about 30k of those.
> but this code would be cleaner without the ifdefs.
Very true. Removing these would be good.
prev parent reply other threads:[~2015-08-03 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 11:18 [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl Shah, Yash (Y.)
2015-08-03 11:33 ` Dan Carpenter
2015-08-03 11:41 ` Joe Perches
2015-08-03 12:09 ` Dan Carpenter
2015-08-03 12:18 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438604297.30149.29.camel@perches.com \
--to=joe@perches.com \
--cc=contact@timothyleung.co \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roxanagabriela10@gmail.com \
--cc=tinajohnson.1234@gmail.com \
--cc=vatikaharlalka@gmail.com \
--cc=yshah1@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox