From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932092AbcF1L7S (ORCPT ); Tue, 28 Jun 2016 07:59:18 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:47823 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbcF1L7P (ORCPT ); Tue, 28 Jun 2016 07:59:15 -0400 X-AuditID: cbfee61a-f79106d000000835-77-57726690b610 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Russell King , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , MyungJoo Ham , Kyungmin Park , linux-pm@vger.kernel.org Subject: Re: [PATCH v2] clk: Provide notifier stubs when !COMMON_CLK Date: Tue, 28 Jun 2016 13:58:49 +0200 Message-id: <14387179.nnNuRe7g05@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1467113104-8650-1-git-send-email-k.kozlowski@samsung.com> References: <1467113104-8650-1-git-send-email-k.kozlowski@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t9jAd0JaUXhBnO+G1q8fmFocbbpDbvF x557rBaXd81hs/jce4TR4tDUvYwWF0+5WtxuXMFm8eNMN4sDp8flaxeZPd7faGX3uNzXy+TR t2UVo8fnTXIBrFFcNimpOZllqUX6dglcGXffbGcuuMxTsa71ClsD4wauLkZODgkBE4lpx5ex QdhiEhfurQeyuTiEBJYySmw6uIkJwvnKKPFp1SNGkCo2ASuJie2rwGwRAUOJg7u3gxUxCyxn kuibdpIdJCEs4CIxb+YtJhCbRUBV4vr5W2AreAW0JK7cP8gKYosKeEn0bIcYyingLtFy6jAL iC0k4CaxvncRI0S9oMSPyffA4swC8hL79k9lhbC1JNbvPM40gVFgFpKyWUjKZiEpW8DIvIpR IrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOPyfSe1gPLjL/RCjAAejEg/vjrrCcCHWxLLi ytxDjBIczEoivM9SisKFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8z7+vy5MSCA9sSQ1OzW1ILUI JsvEwSnVwJhv5TV3SQOHww3LFQISyt8vfFc6dTa87U13nYrm8p+eXxTu2L5S9z7EsFv/+Z5d fdOW344vviXE9ECfM+lAyw81J8NoB2FxwRO/7Ky+m6mahR8+YZj56bjNQvnrqquV83YVX9sY /3CZavoz7iyzq5vOeEn+28hRGnzrYWbPx05WnxtKy/azH1JiKc5INNRiLipOBADevasSewIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, June 28, 2016 01:25:04 PM Krzysztof Kozlowski wrote: > The clk notifier symbols are hidden by COMMON_CLK. However on some > platforms HAVE_CLK might be set while COMMON_CLK not which leads to > compile test build errors like: > > $ make.cross ARCH=sh > drivers/devfreq/tegra-devfreq.c: In function 'tegra_actmon_rate_notify_cb': > >> drivers/devfreq/tegra-devfreq.c:391:16: error: 'POST_RATE_CHANGE' undeclared (first use in this function) > if (action != POST_RATE_CHANGE) > ^ > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_probe': > >> drivers/devfreq/tegra-devfreq.c:654:8: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration] > err = clk_notifier_register(tegra->emc_clock, &tegra->rate_change_nb); > ^ > > Export the macros and data type declarations outside of COMMON_CLK ifdef > and provide stubs to fix the compile testing. > > Reported-by: kbuild test robot > Signed-off-by: Krzysztof Kozlowski > > --- > > Reported when testing patch [1] on ARCH=sh. I don't have the sh cross > compile toolchain so I cannot verify whether this fixes reported issue. FWIW I've verified with sh cross-compiler. Tested-by: Bartlomiej Zolnierkiewicz > Tested on similar configuration on MIPS (HAVE_CLK && !COMMON_CLK) > > [1] http://www.gossamer-threads.com/lists/linux/kernel/2471798 Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics