From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Salah Triki <salah.triki@acm.org>,
minchan@kernel.org, ngupta@vflare.org,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] zram: Replace pr_* with dev_*
Date: Tue, 04 Aug 2015 18:16:05 -0700 [thread overview]
Message-ID: <1438737365.24137.0.camel@perches.com> (raw)
In-Reply-To: <20150804235705.GB4430@swordfish>
On Wed, 2015-08-05 at 08:57 +0900, Sergey Senozhatsky wrote:
> On (08/05/15 08:42), Sergey Senozhatsky wrote:
> > what's the benefit?
>
> and apart from that I don't understand why do you replace some
> pr_info() with dev_warn(). f.e.
And besides that, the formats should not be changed
and still require a '\n' termination to avoid
possible interleaving.
> [..]
> > > if (!zcomp_set_max_streams(zram->comp, num)) {
> > > - pr_info("Cannot change max compression streams\n");
> > > + dev_warn(dev, "Cannot change max compression streams to %d",
> > > + num);
etc...
prev parent reply other threads:[~2015-08-05 1:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 19:22 [PATCH] zram: Replace pr_* with dev_* Salah Triki
2015-08-04 23:42 ` Sergey Senozhatsky
2015-08-04 23:57 ` Sergey Senozhatsky
2015-08-05 1:16 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438737365.24137.0.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=salah.triki@acm.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox