From: Joe Perches <joe@perches.com>
To: Jandy Gou <qingsong.gou@ck-telecom.com>
Cc: gregkh@linuxfoundation.org, oleg.drokin@intel.com,
andreas.dilger@intel.com, jsimmons@infradead.org,
jmmahler@gmail.com, heenasirwani@gmail.com, shuey@purdue.edu,
haticeerturk27@gmail.com, HPDD-discuss@ml01.01.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: Fix coding style errors
Date: Tue, 04 Aug 2015 20:32:50 -0700 [thread overview]
Message-ID: <1438745570.2679.2.camel@perches.com> (raw)
In-Reply-To: <1438675807-11682-2-git-send-email-qingsong.gou@ck-telecom.com>
On Tue, 2015-08-04 at 16:10 +0800, Jandy Gou wrote:
> Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
[]
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
[]
> @@ -721,7 +721,7 @@ kiblnd_nid2peerlist (lnet_nid_t nid)
> unsigned int hash =
> ((unsigned int)nid) % kiblnd_data.kib_peer_hash_size;
>
> - return (&kiblnd_data.kib_peers [hash]);
> + return (&kiblnd_data.kib_peers[hash]);
Please run your own patches though checkpatch and
please remove the unnecessary parenthesis around
the return value at the same time.
prev parent reply other threads:[~2015-08-05 3:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 8:10 [PATCH] Fix coding style error Jandy Gou
2015-08-04 8:10 ` [PATCH] staging: lustre: Fix coding style errors Jandy Gou
2015-08-05 3:32 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438745570.2679.2.camel@perches.com \
--to=joe@perches.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=haticeerturk27@gmail.com \
--cc=heenasirwani@gmail.com \
--cc=jmmahler@gmail.com \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=qingsong.gou@ck-telecom.com \
--cc=shuey@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox