public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix coding style error
@ 2015-08-04  8:10 Jandy Gou
  2015-08-04  8:10 ` [PATCH] staging: lustre: Fix coding style errors Jandy Gou
  0 siblings, 1 reply; 3+ messages in thread
From: Jandy Gou @ 2015-08-04  8:10 UTC (permalink / raw)
  To: gregkh
  Cc: oleg.drokin, andreas.dilger, jsimmons, jmmahler, heenasirwani,
	shuey, haticeerturk27, HPDD-discuss, devel, linux-kernel,
	Jandy Gou

Fix the following two coding style errors:

ERROR: space prohibited before that '++' (ctx:WxO)
#890: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:890:
+		index ++;

ERROR: space prohibited before open square bracket '['
#724: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:724:
+	return (&kiblnd_data.kib_peers [hash]);

Jandy Gou (1):
  staging: lustre: Fix coding style errors

 drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] staging: lustre: Fix coding style errors
  2015-08-04  8:10 [PATCH] Fix coding style error Jandy Gou
@ 2015-08-04  8:10 ` Jandy Gou
  2015-08-05  3:32   ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Jandy Gou @ 2015-08-04  8:10 UTC (permalink / raw)
  To: gregkh
  Cc: oleg.drokin, andreas.dilger, jsimmons, jmmahler, heenasirwani,
	shuey, haticeerturk27, HPDD-discuss, devel, linux-kernel,
	Jandy Gou

Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
---
 drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
index 0d8fa3a..185da2c 100644
--- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
+++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
@@ -721,7 +721,7 @@ kiblnd_nid2peerlist (lnet_nid_t nid)
 	unsigned int hash =
 		((unsigned int)nid) % kiblnd_data.kib_peer_hash_size;
 
-	return (&kiblnd_data.kib_peers [hash]);
+	return (&kiblnd_data.kib_peers[hash]);
 }
 
 static inline int
@@ -887,7 +887,7 @@ kiblnd_rd_consume_frag(kib_rdma_desc_t *rd, int index, __u32 nob)
 		rd->rd_frags[index].rf_addr += nob;
 		rd->rd_frags[index].rf_nob  -= nob;
 	} else {
-		index ++;
+		index++;
 	}
 
 	return index;
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: lustre: Fix coding style errors
  2015-08-04  8:10 ` [PATCH] staging: lustre: Fix coding style errors Jandy Gou
@ 2015-08-05  3:32   ` Joe Perches
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2015-08-05  3:32 UTC (permalink / raw)
  To: Jandy Gou
  Cc: gregkh, oleg.drokin, andreas.dilger, jsimmons, jmmahler,
	heenasirwani, shuey, haticeerturk27, HPDD-discuss, devel,
	linux-kernel

On Tue, 2015-08-04 at 16:10 +0800, Jandy Gou wrote:
> Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
[]
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
[]
> @@ -721,7 +721,7 @@ kiblnd_nid2peerlist (lnet_nid_t nid)
>  	unsigned int hash =
>  		((unsigned int)nid) % kiblnd_data.kib_peer_hash_size;
>  
> -	return (&kiblnd_data.kib_peers [hash]);
> +	return (&kiblnd_data.kib_peers[hash]);

Please run your own patches though checkpatch and
please remove the unnecessary parenthesis around
the return value at the same time.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-05  3:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-04  8:10 [PATCH] Fix coding style error Jandy Gou
2015-08-04  8:10 ` [PATCH] staging: lustre: Fix coding style errors Jandy Gou
2015-08-05  3:32   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox