From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbbHEUMW (ORCPT ); Wed, 5 Aug 2015 16:12:22 -0400 Received: from casper.infradead.org ([85.118.1.10]:39091 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753795AbbHEUMQ (ORCPT ); Wed, 5 Aug 2015 16:12:16 -0400 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Borislav Petkov , David Ahern , Frederic Weisbecker , Jiri Olsa , Milian Wolff , Namhyung Kim , Stephane Eranian Subject: [PATCH 02/12] perf trace: Do not show syscall tracepoint filter in the --no-syscalls case Date: Wed, 5 Aug 2015 17:11:28 -0300 Message-Id: <1438805498-24993-3-git-send-email-acme@kernel.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1438805498-24993-1-git-send-email-acme@kernel.org> References: <1438805498-24993-1-git-send-email-acme@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo We were accessing trace->syscalls.events members even when that struct wasn't initialized, i.e. --no-syscalls was specified on the command line, fix it to show that, still in debug mode, when we have an event qualifier list, i.e. when we actually are doing subset syscall tracing. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Milian Wolff Cc: Namhyung Kim Cc: Stephane Eranian Fixes: 19867b6186f3 ("perf trace: Use event filters for the event qualifier list") Link: http://lkml.kernel.org/n/tip-7980ym6vujgh3yiai0cqzc88@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 06cfa93c0305..3cfca93309ee 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2394,9 +2394,10 @@ static int trace__run(struct trace *trace, int argc, const char **argv) err = trace__set_ev_qualifier_filter(trace); if (err < 0) goto out_errno; - } - pr_debug("%s\n", trace->syscalls.events.sys_exit->filter); + pr_debug("event qualifier tracepoint filter: %s\n", + trace->syscalls.events.sys_exit->filter); + } err = perf_evlist__apply_filters(evlist, &evsel); if (err < 0) -- 2.1.0