* [PATCH] checkpatch: Don't complain about long "Fixes:" lines
@ 2015-08-06 3:44 Michael Ellerman
2015-08-06 3:50 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2015-08-06 3:44 UTC (permalink / raw)
To: linux-kernel, apw, joe
We encourage people to mention the commit they are fixing, if any, using
a Fixes line, see SubmittingPatches.
Although it's not mentioned explicitly, it's preferable if the Fixes
line is not wrapped, so skip Fixes lines when checking for overlength
lines.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5c8e9a3a73c..b3139cb1bf9d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
# Check for line lengths > 75 in commit log, warn once
if ($in_commit_log && !$commit_log_long_line &&
- length($line) > 75) {
+ length($line) > 75 && $line !~ /^\s*Fixes: [0-9a-f]+/i) {
WARN("COMMIT_LOG_LONG_LINE",
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
$commit_log_long_line = 1;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines
2015-08-06 3:44 [PATCH] checkpatch: Don't complain about long "Fixes:" lines Michael Ellerman
@ 2015-08-06 3:50 ` Joe Perches
2015-08-06 6:24 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-08-06 3:50 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linux-kernel, apw
On Thu, 2015-08-06 at 13:44 +1000, Michael Ellerman wrote:
> We encourage people to mention the commit they are fixing, if any, using
> a Fixes line, see SubmittingPatches.
https://lkml.org/lkml/2015/7/31/1271
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines
2015-08-06 3:50 ` Joe Perches
@ 2015-08-06 6:24 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2015-08-06 6:24 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, apw
On Wed, 2015-08-05 at 20:50 -0700, Joe Perches wrote:
> On Thu, 2015-08-06 at 13:44 +1000, Michael Ellerman wrote:
> > We encourage people to mention the commit they are fixing, if any, using
> > a Fixes line, see SubmittingPatches.
>
> https://lkml.org/lkml/2015/7/31/1271
Thanks.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-06 6:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-06 3:44 [PATCH] checkpatch: Don't complain about long "Fixes:" lines Michael Ellerman
2015-08-06 3:50 ` Joe Perches
2015-08-06 6:24 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox