From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbbHFFa1 (ORCPT ); Thu, 6 Aug 2015 01:30:27 -0400 Received: from smtprelay0061.hostedemail.com ([216.40.44.61]:50879 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750912AbbHFFa0 (ORCPT ); Thu, 6 Aug 2015 01:30:26 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:4401:5007:6261:6742:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: balls90_36c93449d043 X-Filterd-Recvd-Size: 2566 Message-ID: <1438839022.2679.49.camel@perches.com> Subject: Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons From: Joe Perches To: Chen Yu Cc: dvhart@infradead.org, akpm@linux-foundation.org, arnd@arndb.de, mchehab@osg.samsung.com, gregkh@linuxfoundation.org, jslaby@suse.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, rui.zhang@intel.com, rafael.j.wysocki@intel.com, mika.westerberg@intel.com Date: Wed, 05 Aug 2015 22:30:22 -0700 In-Reply-To: <1438838165-3791-1-git-send-email-yu.c.chen@intel.com> References: <1438838165-3791-1-git-send-email-yu.c.chen@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-08-06 at 13:16 +0800, Chen Yu wrote: > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can > not detect these buttons on it. style trivia: > diff --git a/drivers/platform/x86/surfacepro3_button.c b/drivers/platform/x86/surfacepro3_button.c [] > +static void surface_button_notify(struct acpi_device *device, u32 event) > +{ [] > + switch (event) { > + case SURFACE_BUTTON_NOTIFY_PRESS_POWER: > + pressed = true; > + /*go through*/ /* fall through */ is more common > + case SURFACE_BUTTON_NOTIFY_PRESS_HOME: > + pressed = true; > + case SURFACE_BUTTON_NOTIFY_RELEASE_HOME: > + key_code = KEY_LEFTMETA; > + break; It may be better to add a comment about the style or maybe add a macro like #define HANDLE_SURFACE_BUTTON_NOTIFY(type, code) \ case SURFACE_BUTTON_NOTIFY_PRESS_##type: \ pressed = true; /* and fall-through */ \ case SURFACE_BUTTON_NOTIFY_RELEASE_##type: \ key_code = code; \ break; > + case SURFACE_BUTTON_NOTIFY_PRESS_VOLUME_UP: > + pressed = true; > + case SURFACE_BUTTON_NOTIFY_RELEASE_VOLUME_UP: > + key_code = KEY_VOLUMEUP; > + break; > + case SURFACE_BUTTON_NOTIFY_PRESS_VOLUME_DOWN: > + pressed = true; > + case SURFACE_BUTTON_NOTIFY_RELEASE_VOLUME_DOWN: > + key_code = KEY_VOLUMEDOWN; > + break; > + default: > + dev_info(&device->dev, > + "Unsupported event [0x%x]\n", event); It might be useful to ratelimit this