From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function
Date: Thu, 06 Aug 2015 12:26:59 +0300 [thread overview]
Message-ID: <1438853219.29746.184.camel@linux.intel.com> (raw)
In-Reply-To: <20150806083004.GI7675@kuha.fi.intel.com>
On Thu, 2015-08-06 at 11:30 +0300, Heikki Krogerus wrote:
> > >
> On Wed, Aug 05, 2015 at 05:07:29PM +0300, Andy Shevchenko wrote:
> > On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote:
> > > +static inline enum rfkill_type rfkill_find_type(const char
> > > *name)
> > > +{
> > > + return 0;
> >
> > Hmm… Besides 0 is implicitly casted to enum type the issue with
> > enums
> > that you rather have to supply existing enum entry. I would suggest
> > to
> > add RFKILL_TYPE_UNKNOWN if _ALL is reserved for some use cases.
>
> Why would you add a new type just for this? You do realize it would
> require adding specific handling all over the place? RFKILL_TYPE_ALL
> (0) is already handled as an invalid type.
It was my thought as well (see *if* in my previous comment).
> Confused?
A bit, yes.
>
> I'll change this and return RFKILL_TYPE_ALL instead of 0.
Excellent!
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-08-06 9:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 13:39 [PATCH 0/5] net: rfkill: gpio: replace platform data with build-in property Heikki Krogerus
2015-08-05 13:39 ` [PATCH 1/5] device property: helper macros for property entry creation Heikki Krogerus
2015-08-05 14:02 ` Andy Shevchenko
2015-08-05 14:12 ` Shevchenko, Andriy
2015-08-06 7:48 ` Heikki Krogerus
2015-08-07 22:08 ` Rafael J. Wysocki
2015-08-05 13:39 ` [PATCH 2/5] net: rfkill: add rfkill_find_type function Heikki Krogerus
2015-08-05 14:07 ` Andy Shevchenko
2015-08-06 8:30 ` Heikki Krogerus
2015-08-06 9:26 ` Andy Shevchenko [this message]
2015-08-06 11:31 ` Sergei Shtylyov
2015-08-13 9:27 ` Johannes Berg
2015-08-13 12:37 ` Heikki Krogerus
2015-08-05 13:39 ` [PATCH 3/5] net: rfkill: gpio: get the name and type from device property Heikki Krogerus
2015-08-05 13:39 ` [PATCH 4/5] ARM: tegra: use build-in device properties with rfkill_gpio Heikki Krogerus
2015-08-05 13:39 ` [PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data Heikki Krogerus
2015-08-05 14:15 ` Andy Shevchenko
2015-08-06 7:22 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438853219.29746.184.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).