From: Joe Perches <joe@perches.com>
To: "Chen, Yu C" <yu.c.chen@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
"jslaby@suse.com" <jslaby@suse.com>,
"dvhart@infradead.org" <dvhart@infradead.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons
Date: Thu, 06 Aug 2015 07:54:37 -0700 [thread overview]
Message-ID: <1438872877.2679.56.camel@perches.com> (raw)
In-Reply-To: <1438860256.2127.37.camel@localhost>
On Thu, 2015-08-06 at 11:20 +0000, Chen, Yu C wrote:
> On Wed, 2015-08-05 at 22:30 -0700, Joe Perches wrote:
[]
> > > + case SURFACE_BUTTON_NOTIFY_PRESS_HOME:
> > > + pressed = true;
> > > + case SURFACE_BUTTON_NOTIFY_RELEASE_HOME:
> > > + key_code = KEY_LEFTMETA;
> > > + break;
> >
> > It may be better to add a comment about the style or
> > maybe add a macro like
> >
> > #define HANDLE_SURFACE_BUTTON_NOTIFY(type, code) \
> > case SURFACE_BUTTON_NOTIFY_PRESS_##type: \
> > pressed = true; /* and fall-through */ \
> > case SURFACE_BUTTON_NOTIFY_RELEASE_##type: \
> > key_code = code; \
> > break;
> >
> WRT macro HANDLE_SURFACE_BUTTON_NOTIFY, the checkpatch.pl
> complains that multi lines of codes should be wrapped in 'do
> while'state, but doing like this might lead to incorrect semantic.
checkpatch is a brainless tool that should be ignored
whenever you want.
> Is it ok to keep these codes and add comments like:
Up to you. It'd OK to do nothing too.
prev parent reply other threads:[~2015-08-06 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 5:16 [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons Chen Yu
2015-08-06 5:30 ` Joe Perches
2015-08-06 11:20 ` Chen, Yu C
2015-08-05 23:47 ` Darren Hart
2015-08-06 18:55 ` Joe Perches
2015-08-11 2:56 ` Darren Hart
2015-08-07 7:49 ` Chen, Yu C
2015-08-06 14:54 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438872877.2679.56.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mika.westerberg@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox