From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbbHFSzg (ORCPT ); Thu, 6 Aug 2015 14:55:36 -0400 Received: from smtprelay0046.hostedemail.com ([216.40.44.46]:46881 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751324AbbHFSze (ORCPT ); Thu, 6 Aug 2015 14:55:34 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:4250:4321:4401:5007:6119:6261:6742:7903:7904:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: dog65_302c264730d5f X-Filterd-Recvd-Size: 2228 Message-ID: <1438887329.2679.64.camel@perches.com> Subject: Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons From: Joe Perches To: Darren Hart Cc: "Chen, Yu C" , "linux-kernel@vger.kernel.org" , "Zhang, Rui" , "jslaby@suse.com" , "platform-driver-x86@vger.kernel.org" , "akpm@linux-foundation.org" , "Wysocki, Rafael J" , "Westerberg, Mika" , "gregkh@linuxfoundation.org" , "mchehab@osg.samsung.com" , "arnd@arndb.de" Date: Thu, 06 Aug 2015 11:55:29 -0700 In-Reply-To: <20150805234715.GB34034@vmdeb7> References: <1438838165-3791-1-git-send-email-yu.c.chen@intel.com> <1438839022.2679.49.camel@perches.com> <1438860256.2127.37.camel@localhost> <20150805234715.GB34034@vmdeb7> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote: > On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote: [] > > Is it ok to keep these codes and add comments like: It's your code Yu, do whatever you think appropriate. > > /* > > * When a button(power button/volume button/home button) is > > * pressed down or released, different ACPI notification codes > > * will be generated. We can distinguish different event code > > * and value of buttons by these notification codes, then pass > > * (EV_KEY, event code(key_code), value(pressed)) to input layer. > > */ > > The commentary is useful regardless. However, I suspect Joe was > referring to the approach pairing the PRESS and RELEASE cases? > True. btw Darren, your computer's email time setting seems off.