Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

Greg KH
2015-08-05T20:15:03Z

On Fri, Jun 12, 2015 at 11:43:26AM -0700, Philip P. Moltmann wrote:
> This helps with debugging vmw_balloon behavior, as it is clear what
> functionality is enabled.
>
> Acked-by: Andy King <acking@vmware.com>
> Signed-off-by: Xavier Deguillard <xdeguillard@vmware.com>
> ---
> drivers/misc/vmw_balloon.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index 72247d9..6eaf7f7 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -46,7 +46,7 @@
>
> MODULE_AUTHOR("VMware, Inc.");
> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> -MODULE_VERSION("1.3.2.0-k");
> +MODULE_VERSION("1.3.3.0-k");

This constant change of module version is annoying, is it really even
needed?

I'll take this, but seriously consider just dropping it entirely as it
doesn't mean anything now that the driver is in the kernel tree.

thanks,

greg k-h