Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

gregkh
2015-08-05T20:40:22Z

On Wed, Aug 05, 2015 at 08:22:35PM +0000, Philip Moltmann wrote:
> Hi,
>
> > > MODULE_AUTHOR("VMware, Inc.");
> > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> > > -MODULE_VERSION("1.3.2.0-k");
> > > +MODULE_VERSION("1.3.3.0-k");
> >
> > This constant change of module version is annoying, is it really even
> > needed?
> >
> > I'll take this, but seriously consider just dropping it entirely as
> > it
> > doesn't mean anything now that the driver is in the kernel tree.
>
> I think this is meant so that we can track which patches got backported
> into RHEL and SLES.

That guarantees all of those patches will conflict and the engineers
will curse your name. Don't do that, it's horrid. What happens if
someone picks one patch, and then skips one, and uses the third? What
would be the "version" then?

Just drop it entirely, it's useless. You have the source, so you know
what changes are done, no need to try to match it up with a random
number.

greg k-h