From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
Salah Triki <salah.triki@acm.org>,
ngupta@vflare.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_*
Date: Fri, 07 Aug 2015 00:12:06 -0700 [thread overview]
Message-ID: <1438931526.2322.14.camel@perches.com> (raw)
In-Reply-To: <20150807065611.GI1891@swordfish>
On Fri, 2015-08-07 at 15:56 +0900, Sergey Senozhatsky wrote:
> On (08/07/15 15:37), Sergey Senozhatsky wrote:
> [..]
> where we had clean and nice
>
> pr_err("Decompression failed!...
> pr_info("Unable to allocate temp memory\n"...
> etc...
>
> now we have monsters
>
> dev_err(disk_to_dev(zram->disk), "Decompression failed!...
> dev_info(disk_to_dev(zram->disk), "Unable to allocate temp memory\n"...
> etc.
[]
> other changes are very questionable... for example
> pr_info("Added device: %s\n", zram->disk->disk_name);
> becomes
> dev_info(disk_to_dev(zram->disk), "Added device: %s\n", zram->disk->disk_name);
>
> why? there is no reason to do this!
This seems a reasonable complaint.
One option is to add some macros like
#define zram_err(zram, fmt, ...) \
dev_err(disk_to_dev((zram)->disk), fmt, ##__VA_ARGS__)
But the overall utility of the proposed changes is
moderately low to non-existent.
next prev parent reply other threads:[~2015-08-07 7:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 22:57 [PATCH 0/3] zram: Replace pr_* with dev_* Salah Triki
2015-08-06 23:03 ` [PATCH 1/3] zram: Replace pr_info with dev_info in max_comp_streams_store Salah Triki
2015-08-06 23:03 ` [PATCH 2/3] zram: Replace pr_info with dev_info in comp_algorithm_store Salah Triki
2015-08-06 23:03 ` [PATCH 3/3] zram: Replace pr_* with dev_* Salah Triki
2015-08-07 0:05 ` [PATCH 0/3] " Sergey Senozhatsky
2015-08-07 1:17 ` Joe Perches
2015-08-07 1:42 ` Sergey Senozhatsky
2015-08-07 1:48 ` Joe Perches
2015-08-07 2:03 ` Sergey Senozhatsky
2015-08-07 2:16 ` Sergey Senozhatsky
2015-08-07 6:05 ` Minchan Kim
2015-08-07 6:37 ` Sergey Senozhatsky
2015-08-07 6:56 ` Sergey Senozhatsky
2015-08-07 7:12 ` Joe Perches [this message]
2015-08-07 7:25 ` Sergey Senozhatsky
2015-08-07 14:58 ` Minchan Kim
2015-08-10 1:25 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438931526.2322.14.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=salah.triki@acm.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox