From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>, Alexander Graf <agraf@suse.com>,
Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 2/4] loop: Enable correct physical blocksize
Date: Fri, 7 Aug 2015 10:54:14 +0200 [thread overview]
Message-ID: <1438937656-27499-3-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1438937656-27499-1-git-send-email-hare@suse.de>
When running on files the physical blocksize is actually 4k,
so we should be announcing it as such. This is enabled with
a new LO_FLAGS_BLOCKSIZE flag value to the existing ioctl.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/block/loop.c | 9 ++++++++-
include/uapi/linux/loop.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index b9e12a0..fce13bd 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -177,6 +177,8 @@ figure_loop_size(struct loop_device *lo, loff_t offset, loff_t sizelimit)
lo->lo_offset = offset;
if (lo->lo_sizelimit != sizelimit)
lo->lo_sizelimit = sizelimit;
+ if (lo->lo_flags & LO_FLAGS_BLOCKSIZE)
+ blk_queue_physical_block_size(lo->lo_queue, lo->lo_blocksize);
set_capacity(lo->lo_disk, x);
bd_set_size(bdev, (loff_t)get_capacity(bdev->bd_disk) << 9);
/* let user-space know about the new size */
@@ -758,7 +760,7 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode,
lo->lo_blocksize = lo_blocksize;
lo->lo_device = bdev;
- lo->lo_flags = lo_flags;
+ lo->lo_flags |= lo_flags;
lo->lo_backing_file = file;
lo->transfer = NULL;
lo->ioctl = NULL;
@@ -769,6 +771,8 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode,
if (!(lo_flags & LO_FLAGS_READ_ONLY) && file->f_op->fsync)
blk_queue_flush(lo->lo_queue, REQ_FLUSH);
+ if (lo->lo_flags & LO_FLAGS_BLOCKSIZE)
+ blk_queue_physical_block_size(lo->lo_queue, lo->lo_blocksize);
set_capacity(lo->lo_disk, size);
bd_set_size(bdev, size << 9);
loop_sysfs_init(lo);
@@ -951,6 +955,9 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
if (err)
return err;
+ if (info->lo_flags & LO_FLAGS_BLOCKSIZE)
+ lo->lo_flags |= LO_FLAGS_BLOCKSIZE;
+
if (lo->lo_offset != info->lo_offset ||
lo->lo_sizelimit != info->lo_sizelimit)
if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit))
diff --git a/include/uapi/linux/loop.h b/include/uapi/linux/loop.h
index e0cecd2..caec9d3 100644
--- a/include/uapi/linux/loop.h
+++ b/include/uapi/linux/loop.h
@@ -21,6 +21,7 @@ enum {
LO_FLAGS_READ_ONLY = 1,
LO_FLAGS_AUTOCLEAR = 4,
LO_FLAGS_PARTSCAN = 8,
+ LO_FLAGS_BLOCKSIZE = 16,
};
#include <asm/posix_types.h> /* for __kernel_old_dev_t */
--
1.8.4.5
next prev parent reply other threads:[~2015-08-07 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 8:54 [PATCHv2 0/4] loop: enable different physical blocksizes Hannes Reinecke
2015-08-07 8:54 ` [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity Hannes Reinecke
2015-08-07 8:54 ` Hannes Reinecke [this message]
2015-08-10 7:50 ` [PATCH 2/4] loop: Enable correct physical blocksize Ming Lei
2015-08-07 8:54 ` [PATCH 3/4] loop: Add 'lo_logical_blocksize' Hannes Reinecke
2015-08-07 8:54 ` [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2016-10-31 19:37 [PATCHv3 0/4] loop: enable different physical blocksizes Hannes Reinecke
2016-10-31 19:37 ` [PATCH 2/4] loop: Enable correct physical blocksize Hannes Reinecke
2016-11-01 14:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438937656-27499-3-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=agraf@suse.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox