From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932209AbbHGOHc (ORCPT ); Fri, 7 Aug 2015 10:07:32 -0400 Received: from mga03.intel.com ([134.134.136.65]:42487 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbbHGOHa (ORCPT ); Fri, 7 Aug 2015 10:07:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,630,1432623600"; d="scan'208";a="537771501" Message-ID: <1438956449.17630.0.camel@linux.intel.com> Subject: Re: [PATCH 1/6] pmem: remove indirection layer arch_has_pmem_api() From: Ross Zwisler To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org, dan.j.williams@intel.com Date: Fri, 07 Aug 2015 08:07:29 -0600 In-Reply-To: <20150807063816.GA11543@infradead.org> References: <1438883000-9011-1-git-send-email-ross.zwisler@linux.intel.com> <1438883000-9011-2-git-send-email-ross.zwisler@linux.intel.com> <20150807063816.GA11543@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-08-06 at 23:38 -0700, Christoph Hellwig wrote: > On Thu, Aug 06, 2015 at 11:43:15AM -0600, Ross Zwisler wrote: > > Prior to this change arch_has_wmb_pmem() was only called by > > arch_has_pmem_api(). Both arch_has_wmb_pmem() and arch_has_pmem_api() > > checked to make sure that CONFIG_ARCH_HAS_PMEM_API was enabled. > > > > Instead, remove one extra layer of indirection and the redundant > > CONFIG_ARCH_HAS_PMEM_API check, and just have arch_has_pmem_api() > > call __arch_has_wmb_pmem() directly. > > The description here matches the codde, but not the suject line.. > > > Reviewed-by: Christoph Hellwig > > with a fixed up subject line. Ah, thank you, will fix.