From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Adrian Huang <ahuang12@lenovo.com>, Egbert Eich <eich@suse.de>,
Diego Ercolani <diego.ercolani@gmail.com>,
Borislav Petkov <bp@suse.de>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Alessandro Zummo <a.zummo@towertech.it>,
<rtc-linux@googlegroups.com>
Subject: [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix
Date: Tue, 11 Aug 2015 10:04:04 -0400 [thread overview]
Message-ID: <1439301844-22710-1-git-send-email-paul.gortmaker@windriver.com> (raw)
We currently see this warning:
drivers/rtc/rtc-cmos.c:851:7: warning: unused variable 'err'
introduced by commit 7b4a008088a28ea936fffbbfa770d0184468a0ce ("rtc-cmos:
Cancel alarm timer if alarm time is equal to now+1 seconds").
Presumably some WIP version of the commit was doing error checking
but then the variable was not removed prior to submission, and the
pending commits weren't on kernel.org for kbuild bot to spot the new
warning created.
Cc: Adrian Huang <ahuang12@lenovo.com>
Cc: Egbert Eich <eich@suse.de>
Cc: Diego Ercolani <diego.ercolani@gmail.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Note: patch is against linux-next, so if the rtc tree is rebased,
then the above commit ID reference will be stale. Feel free to
adjust the commit log appropriately, if need be, or even squash
this into the original offending patch, if rebasing back that far.
Also ensuring your tree is on kernel.org will allow kbuild bot
to spot these on your behalf via the zero day builds.]
drivers/rtc/rtc-cmos.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 916bd1f555e5..c2e90c62a59c 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -848,7 +848,6 @@ static int cmos_aie_poweroff(struct device *dev)
*/
if (cmos->alarm_expires == t_now + 1) {
struct rtc_wkalrm alarm;
- int err;
/* Cancel the AIE timer by configuring the past time. */
rtc_time64_to_tm(t_now - 1, &alarm.time);
--
2.5.0
next reply other threads:[~2015-08-11 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 14:04 Paul Gortmaker [this message]
2015-08-11 14:15 ` [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439301844-22710-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=a.zummo@towertech.it \
--cc=ahuang12@lenovo.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=bp@suse.de \
--cc=diego.ercolani@gmail.com \
--cc=eich@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox