public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
@ 2015-08-17 11:51 Valentin Rothberg
  2015-08-17 13:16 ` Marciniszyn, Mike
  2015-08-18 19:46 ` Marciniszyn, Mike
  0 siblings, 2 replies; 3+ messages in thread
From: Valentin Rothberg @ 2015-08-17 11:51 UTC (permalink / raw)
  To: gregkh, dledford, linux-kernel, mike.marciniszyn; +Cc: Valentin Rothberg

Remove the 'CONFIG_' prefix of the Kconfig options PRESCAN_RXQ and
SDMA_VERBOSITY in Kconfig.  Such prefix in Kconfig requires a double
'CONFIG_CONFIG_' prefix in Make and CPP syntax.

Since both options are referenced in the hfi1 source code as
CONFIG_{PRESCAN_RXQ, SDMA_VERBOSITY} the referencing #ifdef's can now be
compiled.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
Note that this issue was present since the driver's config files have
been added by commit 8214d07e6f21 ("IB/hfi1: add driver make/config
files").  This change does not introduce any build issues, but I cannot
test it.

I detected this issues with scripts/checkkconfigsymbols.py by diffing
next-20150814..next-20150817

 drivers/staging/hfi1/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/hfi1/Kconfig b/drivers/staging/hfi1/Kconfig
index 87a385a02cba..fd25078ee923 100644
--- a/drivers/staging/hfi1/Kconfig
+++ b/drivers/staging/hfi1/Kconfig
@@ -18,14 +18,14 @@ config HFI1_VERBS_31BIT_PSN
 	---help---
 	Setting this enables 31 BIT PSN
 	For verbs RC/UC
-config CONFIG_SDMA_VERBOSITY
+config SDMA_VERBOSITY
 	bool "Config SDMA Verbosity"
 	depends on INFINIBAND_HFI1
 	default n
 	---help---
 	This is a configuration flag to enable verbose
 	SDMA debug
-config CONFIG_PRESCAN_RXQ
+config PRESCAN_RXQ
 	bool "Enable prescanning of the RX queue for ECNs"
 	depends on INFINIBAND_HFI1
 	default n
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
  2015-08-17 11:51 [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix Valentin Rothberg
@ 2015-08-17 13:16 ` Marciniszyn, Mike
  2015-08-18 19:46 ` Marciniszyn, Mike
  1 sibling, 0 replies; 3+ messages in thread
From: Marciniszyn, Mike @ 2015-08-17 13:16 UTC (permalink / raw)
  To: Valentin Rothberg
  Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	dledford@redhat.com, linux-rdma@vger.kernel.org

> Subject: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---

Thanks for the patch!

Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
  2015-08-17 11:51 [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix Valentin Rothberg
  2015-08-17 13:16 ` Marciniszyn, Mike
@ 2015-08-18 19:46 ` Marciniszyn, Mike
  1 sibling, 0 replies; 3+ messages in thread
From: Marciniszyn, Mike @ 2015-08-18 19:46 UTC (permalink / raw)
  To: dledford@redhat.com
  Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Valentin Rothberg, linux-rdma@vger.kernel.org

> Subject: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
> 
> Remove the 'CONFIG_' prefix of the Kconfig options PRESCAN_RXQ and
> SDMA_VERBOSITY in Kconfig.  Such prefix in Kconfig requires a double
> 'CONFIG_CONFIG_' prefix in Make and CPP syntax.
> 

Doug,  can you pull this one in?

There is a Kconfig checker that caught this one!

Mike

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-18 19:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-17 11:51 [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix Valentin Rothberg
2015-08-17 13:16 ` Marciniszyn, Mike
2015-08-18 19:46 ` Marciniszyn, Mike

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox