* [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo
@ 2015-08-19 3:17 Axel Lin
2015-08-19 16:04 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-08-19 3:17 UTC (permalink / raw)
To: Mark Brown
Cc: Bjorn Andersson, Andy Gross, Tim Bird, Liam Girdwood,
linux-kernel
Just setting fixed_uV is not enough, the regulator core will also check
n_voltages setting. The fixed_uV only works when n_voltages is 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/qcom_smd-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 9d093ae..9c6167d 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
static const struct regulator_desc pm8941_lnldo = {
.fixed_uV = 1740000,
+ .n_voltages = 1,
.ops = &rpm_smps_ldo_ops,
};
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo
2015-08-19 3:17 [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo Axel Lin
@ 2015-08-19 16:04 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2015-08-19 16:04 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Andy Gross, Bird, Tim, Liam Girdwood,
linux-kernel@vger.kernel.org
On Tue 18 Aug 20:17 PDT 2015, Axel Lin wrote:
> Just setting fixed_uV is not enough, the regulator core will also check
> n_voltages setting. The fixed_uV only works when n_voltages is 1.
>
Thanks, I missed that.
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 9d093ae..9c6167d 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
>
> static const struct regulator_desc pm8941_lnldo = {
> .fixed_uV = 1740000,
> + .n_voltages = 1,
> .ops = &rpm_smps_ldo_ops,
> };
>
> --
> 2.1.0
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-19 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 3:17 [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo Axel Lin
2015-08-19 16:04 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).