From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbbHTRt5 (ORCPT ); Thu, 20 Aug 2015 13:49:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:56667 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986AbbHTRt4 (ORCPT ); Thu, 20 Aug 2015 13:49:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,715,1432623600"; d="scan'208";a="629196247" Message-ID: <1440092994.30197.5.camel@linux.intel.com> Subject: Re: [PATCH] nvdimm: change to use generic kvfree() From: Ross Zwisler To: yalin wang Cc: dan.j.williams@intel.com, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Date: Thu, 20 Aug 2015 11:49:54 -0600 In-Reply-To: <1440064809-26036-1-git-send-email-yalin.wang2010@gmail.com> References: <1440064809-26036-1-git-send-email-yalin.wang2010@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-08-20 at 18:00 +0800, yalin wang wrote: > Signed-off-by: yalin wang > --- > drivers/nvdimm/dimm_devs.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c > index c05eb80..651b8d1 100644 > --- a/drivers/nvdimm/dimm_devs.c > +++ b/drivers/nvdimm/dimm_devs.c > @@ -241,10 +241,7 @@ void nvdimm_drvdata_release(struct kref *kref) > nvdimm_free_dpa(ndd, res); > nvdimm_bus_unlock(dev); > > - if (ndd->data && is_vmalloc_addr(ndd->data)) > - vfree(ndd->data); > - else > - kfree(ndd->data); > + kvfree(ndd->data); > kfree(ndd); > put_device(dev); > } This seems fine. You're skipping the existing check to see if ndd->data is NULL, but I think that is handled implicitly by is_vmalloc_addr() since NULL won't be in the vmalloc address range. Reviewed-by: Ross Zwisler