* [PATCH] usb: core: driver: Use kmalloc_array
@ 2015-08-23 18:48 Muhammad Falak R Wani
2015-08-23 18:58 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Falak R Wani @ 2015-08-23 18:48 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb, linux-kernel; +Cc: Muhammad Falak R Wani
This patch introduces the use of function kmalloc_array(), instead
of using kmalloc(), for allocating memory for an array and removes
the corresponding call to kmalloc().
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/usb/core/driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 818369a..d19106b 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -416,7 +416,7 @@ static int usb_unbind_interface(struct device *dev)
if (ep->streams == 0)
continue;
if (j == 0) {
- eps = kmalloc(USB_MAXENDPOINTS * sizeof(void *),
+ eps = kmalloc_array(USB_MAXENDPOINTS, sizeof(void *),
GFP_KERNEL);
if (!eps) {
dev_warn(dev, "oom, leaking streams\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: core: driver: Use kmalloc_array
2015-08-23 18:48 [PATCH] usb: core: driver: Use kmalloc_array Muhammad Falak R Wani
@ 2015-08-23 18:58 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-08-23 18:58 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Mon, 2015-08-24 at 00:18 +0530, Muhammad Falak R Wani wrote:
> This patch introduces the use of function kmalloc_array(), instead
> of using kmalloc(), for allocating memory for an array and removes
> the corresponding call to kmalloc().
[]
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
[]
> @@ -416,7 +416,7 @@ static int usb_unbind_interface(struct device *dev)
> if (ep->streams == 0)
> continue;
> if (j == 0) {
> - eps = kmalloc(USB_MAXENDPOINTS * sizeof(void *),
> + eps = kmalloc_array(USB_MAXENDPOINTS, sizeof(void *),
> GFP_KERNEL);
> if (!eps) {
> dev_warn(dev, "oom, leaking streams\n");
Allocations like this really don't need to use
kmalloc_array as it's unlikely that USB_MAXENDPOINTS
is very large.
If you are going to do this, it'd be nicer to keep
the parenthesis alignment and likely also better to
remove the dev_warn for a memory leak.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-23 18:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-23 18:48 [PATCH] usb: core: driver: Use kmalloc_array Muhammad Falak R Wani
2015-08-23 18:58 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox