public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <x86@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 0/3] x86: fix instances of non-modular code using modular fcns
Date: Mon, 24 Aug 2015 19:34:52 -0400	[thread overview]
Message-ID: <1440459295-21814-1-git-send-email-paul.gortmaker@windriver.com> (raw)

In the previous merge window, we made changes to allow better
delineation between modular and non-modular code in commit
0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init
from init.h to module.h").  This allows us to now ensure module code
looks modular and non-modular code does not accidentally look modular
without suffering build breakage from header entanglement.

Here we target x86 code that is, by nature of the Kconfig/Makefile, only
available to be built-in, but implicitly presenting itself as being
possibly modular by way of using modular headers and macros.

The goal here is to remove that illusion of modularity from these
files, but in a way that leaves the actual runtime unchanged.
We also get the side benefit of a reduced CPP overhead, since the
removal of module.h from a file can reduce the number of lines emitted
by 20k.

Two of the three are the trivial mapping of module_init onto the
equivalent device_initcall ; the pmc_atom change is that too, but also
includes the removal of a no-op MODULE_DEVICE_TABLE and a corrected
comment relating to that, hence the larger diffstat there.

Paul.
---

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org


Paul Gortmaker (3):
  x86/platform: make atom/pmc_atom.c explicitly non-modular
  arch/x86: make mm/pageattr[-test].c explicitly non-modular
  arch/x86: make kernel/check.c explicitly non-modular

 arch/x86/kernel/check.c           |  5 ++---
 arch/x86/mm/pageattr-test.c       |  4 ++--
 arch/x86/mm/pageattr.c            |  1 -
 arch/x86/platform/atom/pmc_atom.c | 13 ++++---------
 4 files changed, 8 insertions(+), 15 deletions(-)

-- 
2.5.0


             reply	other threads:[~2015-08-24 23:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 23:34 Paul Gortmaker [this message]
2015-08-24 23:34 ` [PATCH 1/3] x86/platform: make atom/pmc_atom.c explicitly non-modular Paul Gortmaker
2015-08-25  8:22   ` [tip:x86/platform] x86/platform: Make atom/ pmc_atom.c " tip-bot for Paul Gortmaker
2015-08-24 23:34 ` [PATCH 2/3] arch/x86: make mm/pageattr[-test].c " Paul Gortmaker
2015-08-25  8:22   ` [tip:x86/mm] x86/mm/pat: Make mm/pageattr[-test] .c " tip-bot for Paul Gortmaker
2015-08-24 23:34 ` [PATCH 3/3] arch/x86: make kernel/check.c " Paul Gortmaker
2015-08-25  8:22   ` [tip:x86/mm] x86/mm: Make " tip-bot for Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440459295-21814-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox