From: Peng Sun <sironhide0null@gmail.com>
To: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Peng Sun <sironhide0null@gmail.com>
Subject: [PATCH 5/6] fix android/sync.h several coding style issues
Date: Tue, 25 Aug 2015 14:53:51 +0800 [thread overview]
Message-ID: <1440485632-17242-6-git-send-email-sironhide0null@gmail.com> (raw)
In-Reply-To: <1440485632-17242-5-git-send-email-sironhide0null@gmail.com>
Corrections based on checkpatch.pl with --strict
1) spinlock_t definition without comment
2) Alignment should match open parenthesis
Signed-off-by: Peng Sun <sironhide0null@gmail.com>
---
drivers/staging/android/sync.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h
index 61f8a3a..87358d2 100644
--- a/drivers/staging/android/sync.h
+++ b/drivers/staging/android/sync.h
@@ -94,12 +94,11 @@ struct sync_timeline {
const struct sync_timeline_ops *ops;
char name[32];
- /* protected by child_list_lock */
bool destroyed;
int context, value;
struct list_head child_list_head;
- spinlock_t child_list_lock;
+ spinlock_t child_list_lock; /* protect destroyed */
struct list_head active_list_head;
@@ -351,6 +350,6 @@ void sync_dump(void);
# define sync_dump()
#endif
int sync_fence_wake_up_wq(wait_queue_t *curr, unsigned mode,
- int wake_flags, void *key);
+ int wake_flags, void *key);
#endif /* _LINUX_SYNC_H */
--
1.9.1
next prev parent reply other threads:[~2015-08-25 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 6:53 [PATCH 0/6] fix drivers/staging/android several coding issues Peng Sun
2015-08-25 6:53 ` [PATCH 1/6] fix android/ashmem.c several coding style issues Peng Sun
2015-08-25 6:53 ` [PATCH 2/6] fix android/lowmemorykiller.c " Peng Sun
2015-08-25 6:53 ` [PATCH 3/6] fix android/sw_sync.c " Peng Sun
2015-08-25 6:53 ` [PATCH 4/6] fix android/sync.c " Peng Sun
2015-08-25 6:53 ` Peng Sun [this message]
2015-08-25 6:53 ` [PATCH 6/6] fix android/timed_gpio.c " Peng Sun
2015-08-25 15:18 ` [PATCH 0/6] fix drivers/staging/android several coding issues Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440485632-17242-6-git-send-email-sironhide0null@gmail.com \
--to=sironhide0null@gmail.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox