public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peng Sun <sironhide0null@gmail.com>
To: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Peng Sun <sironhide0null@gmail.com>
Subject: [PATCH 6/6] fix android/timed_gpio.c several coding style issues
Date: Tue, 25 Aug 2015 14:53:52 +0800	[thread overview]
Message-ID: <1440485632-17242-7-git-send-email-sironhide0null@gmail.com> (raw)
In-Reply-To: <1440485632-17242-6-git-send-email-sironhide0null@gmail.com>

Corrections based on checkpatch.pl with --strict
1) Please don't use multiple blank lines
2) spinlock_t definition without comment
3) Alignment should match open parenthesis

Signed-off-by: Peng Sun <sironhide0null@gmail.com>
---
 drivers/staging/android/timed_gpio.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c
index ce11726..33acbbe 100644
--- a/drivers/staging/android/timed_gpio.c
+++ b/drivers/staging/android/timed_gpio.c
@@ -25,11 +25,10 @@
 #include "timed_output.h"
 #include "timed_gpio.h"
 
-
 struct timed_gpio_data {
 	struct timed_output_dev dev;
 	struct hrtimer timer;
-	spinlock_t lock;
+	spinlock_t lock; /* protect structure fields */
 	unsigned gpio;
 	int max_timeout;
 	u8 active_low;
@@ -76,8 +75,9 @@ static void gpio_enable(struct timed_output_dev *dev, int value)
 			value = data->max_timeout;
 
 		hrtimer_start(&data->timer,
-			ktime_set(value / 1000, (value % 1000) * 1000000),
-			HRTIMER_MODE_REL);
+			      ktime_set(value / 1000, (value % 1000) *
+					1000000),
+			      HRTIMER_MODE_REL);
 	}
 
 	spin_unlock_irqrestore(&data->lock, flags);
@@ -94,8 +94,9 @@ static int timed_gpio_probe(struct platform_device *pdev)
 		return -EBUSY;
 
 	gpio_data = devm_kzalloc(&pdev->dev,
-			sizeof(struct timed_gpio_data) * pdata->num_gpios,
-			GFP_KERNEL);
+				 sizeof(struct timed_gpio_data) *
+				 pdata->num_gpios,
+				 GFP_KERNEL);
 	if (!gpio_data)
 		return -ENOMEM;
 
@@ -104,7 +105,7 @@ static int timed_gpio_probe(struct platform_device *pdev)
 		gpio_dat = &gpio_data[i];
 
 		hrtimer_init(&gpio_dat->timer, CLOCK_MONOTONIC,
-				HRTIMER_MODE_REL);
+			     HRTIMER_MODE_REL);
 		gpio_dat->timer.function = gpio_timer_func;
 		spin_lock_init(&gpio_dat->lock);
 
-- 
1.9.1


  reply	other threads:[~2015-08-25  6:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  6:53 [PATCH 0/6] fix drivers/staging/android several coding issues Peng Sun
2015-08-25  6:53 ` [PATCH 1/6] fix android/ashmem.c several coding style issues Peng Sun
2015-08-25  6:53   ` [PATCH 2/6] fix android/lowmemorykiller.c " Peng Sun
2015-08-25  6:53     ` [PATCH 3/6] fix android/sw_sync.c " Peng Sun
2015-08-25  6:53       ` [PATCH 4/6] fix android/sync.c " Peng Sun
2015-08-25  6:53         ` [PATCH 5/6] fix android/sync.h " Peng Sun
2015-08-25  6:53           ` Peng Sun [this message]
2015-08-25 15:18 ` [PATCH 0/6] fix drivers/staging/android several coding issues Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440485632-17242-7-git-send-email-sironhide0null@gmail.com \
    --to=sironhide0null@gmail.com \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox