From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756824AbbHZMEK (ORCPT ); Wed, 26 Aug 2015 08:04:10 -0400 Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:54467 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756675AbbHZMEH (ORCPT ); Wed, 26 Aug 2015 08:04:07 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2693:2737:2828:2911:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:4321:4362:4425:5007:6261:6742:7903:7974:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: offer20_5d88f1c726141 X-Filterd-Recvd-Size: 1897 Message-ID: <1440590641.2670.187.camel@perches.com> Subject: Re: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons From: Joe Perches To: Darren Hart Cc: Chen Yu , akpm@linux-foundation.org, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, davem@davemloft.net, jslaby@suse.com, tj@kernel.org, rjw@rjwysocki.net, rui.zhang@intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 26 Aug 2015 05:04:01 -0700 In-Reply-To: <20150826072221.GD50910@vmdeb7> References: <1439911825-23536-1-git-send-email-yu.c.chen@intel.com> <20150826072221.GD50910@vmdeb7> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote: > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote: > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can > > not detect these buttons on it. According to bios implementation, > > Surface Pro 3 encapsulates these buttons in a device named "VGBI", > > with _HID "MSHW0028". When any of the buttons is pressed, a specify > > ACPI notification code for this button will be delivered to "VGBI". For > > example, if power button is pressed down, ACPI notification code of 0xc6 > > will be sent by Notify(VGBI, 0xc6). [] > Joe, you provided a lot of review, are you happy with this version? It looks fine. Thanks for picking the other little nits too Darren.