Re: [PATCH v2] soc: qcom: smd: Use correct remote processor ID

Stanimir Varbanov
2015-08-27T15:26:53Z

On 08/26/2015 10:42 PM, Andy Gross wrote:
> This patch fixes SMEM addressing issues when remote processors need to use
> secure SMEM partitions.
>
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
> .../devicetree/bindings/soc/qcom/qcom,smd.txt | 6 ++++++
> drivers/soc/qcom/smd.c | 15 +++++++++++----
> 2 files changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> index f65c76d..97d9b3e 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> @@ -37,6 +37,12 @@ The edge is described by the following properties:
> Definition: the identifier of the remote processor in the smd channel
> allocation table
>
> +- qcom,remote-pid:
> + Usage: optional
> + Value type: <u32>
> + Definition: the identifier for the remote processor as known by the rest
> + of the system.
> +
> = SMD DEVICES
>
> In turn, subnodes of the "edges" represent devices tied to SMD channels on that
> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
> index 327adcf..5706a81 100644
> --- a/drivers/soc/qcom/smd.c
> +++ b/drivers/soc/qcom/smd.c
> @@ -111,6 +111,7 @@ struct qcom_smd_edge {
> struct qcom_smd *smd;
> struct device_node *of_node;
> unsigned edge_id;
> + unsigned remote_pid;

Andy, you forgot to add this new field in structure description header.

<snip>

--
regards,
Stan