Re: [PATCH v2] soc: qcom: smd: Use correct remote processor ID

Andy Gross
2015-08-27T16:32:05Z

On Thu, Aug 27, 2015 at 06:26:45PM +0300, Stanimir Varbanov wrote:
> On 08/26/2015 10:42 PM, Andy Gross wrote:
> > This patch fixes SMEM addressing issues when remote processors need to use
> > secure SMEM partitions.
> >
> > Signed-off-by: Andy Gross <agross@codeaurora.org>
> > ---
> > .../devicetree/bindings/soc/qcom/qcom,smd.txt | 6 ++++++
> > drivers/soc/qcom/smd.c | 15 +++++++++++----
> > 2 files changed, 17 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> > index f65c76d..97d9b3e 100644
> > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> > @@ -37,6 +37,12 @@ The edge is described by the following properties:
> > Definition: the identifier of the remote processor in the smd channel
> > allocation table
> >
> > +- qcom,remote-pid:
> > + Usage: optional
> > + Value type: <u32>
> > + Definition: the identifier for the remote processor as known by the rest
> > + of the system.
> > +
> > = SMD DEVICES
> >
> > In turn, subnodes of the "edges" represent devices tied to SMD channels on that
> > diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
> > index 327adcf..5706a81 100644
> > --- a/drivers/soc/qcom/smd.c
> > +++ b/drivers/soc/qcom/smd.c
> > @@ -111,6 +111,7 @@ struct qcom_smd_edge {
> > struct qcom_smd *smd;
> > struct device_node *of_node;
> > unsigned edge_id;
> > + unsigned remote_pid;
>
> Andy, you forgot to add this new field in structure description header.

Good catch. Thanks!

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project