From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbbH2Xxh (ORCPT ); Sat, 29 Aug 2015 19:53:37 -0400 Received: from smtprelay0151.hostedemail.com ([216.40.44.151]:57572 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752825AbbH2Xxg (ORCPT ); Sat, 29 Aug 2015 19:53:36 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:4321:5007:6119:6261:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12438:12517:12519:12740:13019:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: chalk62_3c33a2071ba27 X-Filterd-Recvd-Size: 1693 Message-ID: <1440892412.3276.10.camel@perches.com> Subject: Re: [PATCH 8/8] staging: lustre: put constant on the right of binary operator From: Joe Perches To: Julia Lawall Cc: Oleg Drokin , kernel-janitors@vger.kernel.org, Andreas Dilger , Greg Kroah-Hartman , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 29 Aug 2015 16:53:32 -0700 In-Reply-To: <1440869412-4899-9-git-send-email-Julia.Lawall@lip6.fr> References: <1440869412-4899-1-git-send-email-Julia.Lawall@lip6.fr> <1440869412-4899-9-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-08-29 at 19:30 +0200, Julia Lawall wrote: > Move constants to the right of binary operators. [] > diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c [] > @@ -2954,7 +2954,7 @@ void ptlrpc_init_xid(void) > } > > /* Always need to be aligned to a power-of-two for multi-bulk BRW */ > - CLASSERT((PTLRPC_BULK_OPS_COUNT & (PTLRPC_BULK_OPS_COUNT - 1)) == 0); > + CLASSERT(((PTLRPC_BULK_OPS_COUNT - 1) & PTLRPC_BULK_OPS_COUNT) == 0); This one would probably be better as CLASSERT(is_power_of_2(PTLRPC_BULK_OPS_COUNT));