public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: naresh.kamboju@linaro.org
Cc: linux-kernel@vger.kernel.org, tyler.baker@linaro.org,
	milosz.wasilewski@linaro.org, shuahkh@osg.samsung.com,
	alexey.kodanev@oracle.com
Subject: Re: [PATCH v3] selftests/zram: Adding zram tests
Date: Mon, 31 Aug 2015 14:07:50 +1000	[thread overview]
Message-ID: <1440994070.5735.5.camel@ellerman.id.au> (raw)
In-Reply-To: <1439881319-9727-1-git-send-email-naresh.kamboju@linaro.org>

On Tue, 2015-08-18 at 12:31 +0530, naresh.kamboju@linaro.org wrote:
> From: Naresh Kamboju <naresh.kamboju@linaro.org>
> 
> diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile
> new file mode 100644
> index 0000000..ec45513
> --- /dev/null
> +++ b/tools/testing/selftests/zram/Makefile
> @@ -0,0 +1,12 @@
> +all:
> +
> +TEST_PROGS := zram.sh
> +TEST_FILES := zram01.sh zram02.sh zram_lib.sh
> +
> +include ../lib.mk
> +
> +run_tests:
> +	@/bin/bash ./zram.sh
> +

This is wrong, it gives me:

$ make TARGETS=zram install
...
Makefile:9: warning: overriding recipe for target 'run_tests'
../lib.mk:12: warning: ignoring old recipe for target 'run_tests'


If you want to define run_tests you need to do:

override define RUN_TESTS
	./zram.sh
endef


BUT, I don't see any reason why you need to override run_tests. The default
rule will just run TEST_PROGS, which is zram.sh so that should work fine?

cheers



  parent reply	other threads:[~2015-08-31  4:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  7:01 [PATCH v3] selftests/zram: Adding zram tests naresh.kamboju
2015-08-27 18:10 ` Shuah Khan
2015-08-27 22:12   ` Shuah Khan
2015-08-31 11:49     ` Naresh Kamboju
2015-08-31  4:07 ` Michael Ellerman [this message]
2015-08-31 12:19   ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440994070.5735.5.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=alexey.kodanev@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milosz.wasilewski@linaro.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=tyler.baker@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox