From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbbHaOCH (ORCPT ); Mon, 31 Aug 2015 10:02:07 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:34216 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753489AbbHaOCD (ORCPT ); Mon, 31 Aug 2015 10:02:03 -0400 Message-ID: <1441029718.13930.4.camel@HansenPartnership.com> Subject: Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag From: James Bottomley To: "K. Y. Srinivasan" Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, hch@infradead.org, linux-scsi@vger.kernel.org, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, stable@vger.kernel.org Date: Mon, 31 Aug 2015 08:01:58 -0600 In-Reply-To: <1441034514-18853-1-git-send-email-kys@microsoft.com> References: <1441034514-18853-1-git-send-email-kys@microsoft.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan > Cc: stable@vger.kernel.org > --- > drivers/scsi/storvsc_drv.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 40c43ae..ad8c4bc 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) > vm_srb->win8_extension.time_out_value = 60; > > vm_srb->win8_extension.srb_flags |= > - (SRB_FLAGS_QUEUE_ACTION_ENABLE | > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER); > + SRB_FLAGS_DISABLE_SYNCH_TRANSFER; > > /* Build the SRB */ > switch (scmnd->sc_data_direction) {