From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbbHaT6e (ORCPT ); Mon, 31 Aug 2015 15:58:34 -0400 Received: from mail-bn1bon0115.outbound.protection.outlook.com ([157.56.111.115]:24199 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751129AbbHaT6c (ORCPT ); Mon, 31 Aug 2015 15:58:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1441051104.4966.41.camel@freescale.com> Subject: Re: [PATCH 21/22] xfs: %pF is only for function pointers From: Scott Wood To: Steven Rostedt CC: Dave Chinner , , , Date: Mon, 31 Aug 2015 14:58:24 -0500 In-Reply-To: <20150831154521.1c9353b6@gandalf.local.home> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-21-git-send-email-scottwood@freescale.com> <20150831080657.GF26895@dastard> <1441049065.4966.38.camel@freescale.com> <20150831154521.1c9353b6@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR11CA0053.namprd11.prod.outlook.com (10.141.30.21) To CY1PR03MB1487.namprd03.prod.outlook.com (25.163.17.17) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;2:DJwdT4KMFQlnoql42ZE+3cLYhDHSdNiQLubuHDjt4B8frki7SktKVIZlwfG3UbBTy4n11volvXk/Ue90qO/J4EhEiLQbW7psQxLkWK1tcYxsGS9mgOX2nYEoZdEQ61k6lJatCGAQ02ZxlNprAfuvEfW6H9WU/NB4KsGmRbbSNnM=;3:RWex3ih4T+WHm7oGxTHeyiPF3IVzUkZChVC8yagpEPGVujHUSWOFU3dnSnvui1IXEX97DlMwCoXxOF2tl4qp2bEDR52Vphh61F6oT8ohUbDVwQOmmMUoQm3RxTWhtP85hLj5UE7hXQIdIXBmkc6wSQ==;25:EO/xRlF913pGAL4mrUaH2pDk0zsvXZc2Qk+hFv66tOFBayXT36aLJ0NG9AnRZk+Qpn9IRzHMomawqBRPVl0sOazwDL5miZkxtRSim8PPPJklllbaVGyIvSVs+5i4GhFiBxz64EbzKCSnlZCJhmdgs+tT65xIZxJ/AJkcivE/sApvObqTQQ2vSUSnF971tK7RO1o08MB97psVvbnq8MqIEN4NHrZBR67Nxy0wO64IYwfBQeQi9B1Dk/WvkKPVCE9X X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;20:gWlXA5YizYard+hN+lnU0ZCspXpd7W9XE/Xzl2vCriymbCtcp65TM6nND9+frh2CH6XK5y61P8e0RgCFYZhgeb1IocEQXwnOSlj5WunSEB2qKnPfLZr9wbsD23GO2mH9wEWoMsNNaDDCxpNCHlr7lPNqxNtihZ2jbRzmXITYfln4ptXJ64PcpeXQwjPp1pYwmZLFNJ/+XR4pTX8gBRj/6kZdTpLLmSGuwYcJeyj5wCAZiPbgTYDcApT7zI7b6+zQfczzlbsYIxPgqw7xBJaBHTkh7KAJm5vKJ/K9coC9a4Y7Vm5Hmno8fWTCd3xCVIy06UgAyzmyMk/4wOjCWYSy0iNNo/qBzRJoVnSLbLcSno68+DaAalIS1SYAN96UNjbV25jRud1oD91pjvDo+g0rhUbolvdwlqEBK210mGt4KChJjrqQc5STkJv798F4LAY0mnh4MQw7+p3+mPUF21ePWr+vDRWX/f84qq8wXtN4jBPntVRm5fcmDlXH48/Gt6jz;4:lOiodZ47Dq36Ad2RKLJMNkUDgyb+0hoOclEM3Q0r6dkfogYZ/pnQxLo8VDPSNp8qjXqDo5/mO4N3eBPZ1+aMo/kiN74wFqDQLj+Ty78hXMx7nV0wGBRIzS2bniGwHaylgCGlM9bppkXYtKplcNFTuMMMMc3PaA2WBM9g93RX/kElzdXHD3QBKf/yfjHL9osffcFgf3+gbVXijAkFTqF5RxQN56fq5MO9ZVxkHQVM1laXa19Pai7ozVyBU3tk4tm9FD2WUjFEoSl1UHqu9JQvSKU+Kae4zdhSKsifyGOmUFtaw944r9yrBQqFuh0Oghju X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Forefront-PRVS: 0685122203 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(377424004)(24454002)(64706001)(62966003)(189998001)(103116003)(77096005)(5004730100002)(40100003)(50226001)(87976001)(19580405001)(47776003)(19580395003)(68736005)(2950100001)(5007970100001)(33646002)(46102003)(122386002)(92566002)(93886004)(76176999)(5001830100001)(81156007)(4001540100001)(50986999)(5001960100002)(110136002)(106356001)(86362001)(42186005)(5001860100001)(101416001)(23676002)(50466002)(5820100001)(105586002)(36756003)(77156002)(97736004)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg3OzIzOm5acGpQWEplekhMRC9GWnZVQnFObHhiNU84?= =?utf-8?B?WXZGUWo3SlJCZUpBNDgxYXZPTkVtQlNtcmNOeEVKWk5jZCtEQXFoSVJZTUpw?= =?utf-8?B?TlZyMXREUXppamZRTm1JeWRMMHBySlRQSi9qbGNuTmxmdklabmVIQzZJajFK?= =?utf-8?B?VTh4QkV2UjVoV3UvVTVONlNjTGhyWnRXUWxOclVNZWVSblMrdzBCTFcvSTB2?= =?utf-8?B?T2lWMEJROVZyaGxpY1phdWNFcnU1bzljbUpTaTdVRkl6ZWc2aGFxTlVqSjdh?= =?utf-8?B?RVozQm5xM3lBei9ic0M3VXphNmwrdnFPUDJLUlc4RWc4WVZsc1p1ai9FR3d4?= =?utf-8?B?Z3QvVC9GMExzdTRENjhYWHVWbXphTkRnTEJkcndrOWFibC83SEZRN2V0bFJZ?= =?utf-8?B?d0x3R2plcmp2VDQ4QloxSmpUZDFYcnR6TUEwZ1dLSXorY1RYbmVKUjRtQmFF?= =?utf-8?B?cmk0K3pRWnFmRlBTTEdqTDlyK0ovYVZTeVo5QlJOSFFhOGNqeUJQUG1PQnZq?= =?utf-8?B?aThRaDIvZ2tUKzlwSmhVOXVFVnJBNDhWWk54RHNKKzlQQVRIaFlKL25kWk5v?= =?utf-8?B?TFBmMmhhUEJMOTBneFRMdlNFUi9SVEtLbXNXQUpLd3pBRWVRQ01aZDdTcENa?= =?utf-8?B?MVRRRFhtOHdrS01yckQxaWowemxPY0NXY2dBRWtjSCtaL2lXc2tBK1FaQ2l2?= =?utf-8?B?c0ZGZi9keDdacnNwMVgrSGZtejRYZ2g3OUxUS0ZnZ0pHSCtrK0dkWjliL2NT?= =?utf-8?B?bXZYeFVBYnQyUDQ4UmVFcHh5ZVpIM08wa05peUsxVXAvWHpEZjFmSld1VGdT?= =?utf-8?B?OWlqRWFxdGJKYy9uZzNhak15QmtkM3VOQWhFQjFtR2t1d2x1bU5wY0RLV2NR?= =?utf-8?B?L0VicFBTNHRNWFgyeHp5TitHOS9RVWRpL0hNeEVPYnNYZXVzQTJxK1A1WGZt?= =?utf-8?B?ZTFWT0JnK1lJUVp4dTZ0aVNXYkpGcUt6aXdqTUdMMWIvTDlKQ3YyU1c5aytl?= =?utf-8?B?TlZEVUhPR05yU0ROWmZwMnJESm90YXhrYkRxVUJsK3YrYmo1R0UrbVJuTVhD?= =?utf-8?B?dGprdGp5VlFYVTdkVVFqQkljVHVjeGVENW9XVEkyREdMVm9EUmJndytSaSs5?= =?utf-8?B?L01uZHppVGdmTlVoZDdqK284MU9UZU9rYitxbXFjZG9tYVV2TklRRGdXOWto?= =?utf-8?B?c3VMR1UyVTRURmN3ekZ5T0tkcm1QcHJCVldBYndQK2dQUTkwTUMvaGgzQ1lC?= =?utf-8?B?MlhjbWZnOHRGa1JwR05LOWUxTDdnMkt3djU4bjFZd1h3UGg1cjR4N2xnTnky?= =?utf-8?B?RjllQjRZeUt3NE5NdDIvY3BLVUFielJrNkhCRy9ZeUp5ZEcyWC9OaWxCNm0y?= =?utf-8?B?MkE5MklQWkRKdk1qMFhPUWlqb3hKa0FMaGs5NXhZakQ1bm1QSFRMQWVFQUhl?= =?utf-8?B?aTlld1pyMVNBalhqRkdUTEpkZXo5REZsMTZXdmhwdCt0eU5CRC8zM0xpS3Ji?= =?utf-8?B?a3k0N1VHbVQweVRaejNkY2YyUEhGQzMxYjVkZGkrdmxTdXdjTmFsQ0pIUkFj?= =?utf-8?B?TnNkNHpqeW5yMjVlaDk2a0xHd0NydVZQQmtHaU5La3pTckIvTmhsSFdMZGsz?= =?utf-8?B?cXNOSzY3elE2UEJnZXA2TEtaemFNamdkZGJuNmo0dGdidFdRN2RkWVh0aVgw?= =?utf-8?Q?f8bmeeauG1LsPcDRMeEZXCN/UFzLdJo5a4CtHO4?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;5:PfZhBmEvEcw03LjUXuWIljAOq/GjKktXJe5dquRp8wtKNBSY03TxWJXkmVdBP0FrvTfOye+heE4Fjf8hUQzgxkZ7Wtb2pfHMdgE67CoxpAU3KTwvXWCVh9jNLkUD2ItIe/fvHKE4wXOWbAadQYktVg==;24:8VPYVvhtfAdEnfs78YdGfPBFqSHCP29Dlkrf4jJRPEokYfsfK2/g6Q+hHceUOx2V5F5DRXq2MY9QLEJB+0LrvLV5CH0LnvZhJ5Ue8nW3aws=;20:EJmVKgg/qlgr/Vlm9i1VnUKgtPdH6xuiMdeqCQysWALu7Yi9BPSFBeVEuIEEYsVYNsmRc68IIu310SSLmWNwzQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2015 19:58:29.7541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-08-31 at 15:45 -0400, Steven Rostedt wrote: > On Mon, 31 Aug 2015 14:24:25 -0500 > Scott Wood wrote: > > > > Can you please look into why this change broke the tracing output > > > on x86-64 - if there is no obvious/easy fix for it, then I'm simply > > > going to revert it because having the tracing work correctly on > > > x86-64 is far more important to us than ppc64 or ia64.... > > > > It looks like the cause is that TP_printk() is not really printk() -- it > > actually passes the format to userspace which has its own, not 100% > > compatible implementation pretty_print() in tools/lib/traceevent/event- > > parse.c. %pf in that function behaves like %ps in the kernel, and %ps is > > absent. > > > > We can fix that with adding %ps to the traceevent library. I wasn't sure if this would be considered a stable ABI issue, as it's not about the events themselves, but about the event mechanism. -Scott