From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752804AbbIAUbb (ORCPT ); Tue, 1 Sep 2015 16:31:31 -0400 Received: from smtprelay0248.hostedemail.com ([216.40.44.248]:55095 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751180AbbIAUba (ORCPT ); Tue, 1 Sep 2015 16:31:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3873:4250:4321:4823:5007:6119:6238:6261:8784:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13019:13161:13229:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: spark52_470300ac7fb34 X-Filterd-Recvd-Size: 3412 Message-ID: <1441139486.12163.3.camel@perches.com> Subject: Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue From: Joe Perches To: Vaibhav Hiremath Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 01 Sep 2015 13:31:26 -0700 In-Reply-To: <1441135454-6902-2-git-send-email-vaibhav.hiremath@linaro.org> References: <1441135454-6902-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135454-6902-2-git-send-email-vaibhav.hiremath@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > There were some coding style issues where spaces have been used instead > of tabs, for example, in macro definitions, alignment of function > declarations/definitions, etc... > > This patch fixes all such occurrences in the code. > And also use BIT for bit definitions. Please send 2 patches instead. > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c [] > @@ -128,7 +133,7 @@ static int mv_conf_mbus_windows(struct platform_device *pdev, > } > > static int armada_38x_quirks(struct platform_device *pdev, > - struct sdhci_host *host) > + struct sdhci_host *host) This is not an improvement. The old code is aligned to the open parenthesis and is fine. > @@ -284,10 +288,10 @@ static void pxav3_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs) > * FE-2946959 > */ > if (pxa->sdio3_conf_reg) { > - u8 reg_val = readb(pxa->sdio3_conf_reg); > + u8 reg_val = readb(pxa->sdio3_conf_reg); > > if (uhs == MMC_TIMING_UHS_SDR50 || > - uhs == MMC_TIMING_UHS_DDR50) { > + uhs == MMC_TIMING_UHS_DDR50) { Also not an improvement. > @@ -304,20 +308,20 @@ static void pxav3_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs) > } > > static const struct sdhci_ops pxav3_sdhci_ops = { > - .set_clock = sdhci_set_clock, > - .platform_send_init_74_clocks = pxav3_gen_init_74_clocks, > - .get_max_clock = sdhci_pltfm_clk_get_max_clock, > - .set_bus_width = sdhci_set_bus_width, > - .reset = pxav3_reset, > - .set_uhs_signaling = pxav3_set_uhs_signaling, > + .set_clock = sdhci_set_clock, > + .platform_send_init_74_clocks = pxav3_gen_init_74_clocks, > + .get_max_clock = sdhci_pltfm_clk_get_max_clock, > + .set_bus_width = sdhci_set_bus_width, > + .reset = pxav3_reset, > + .set_uhs_signaling = pxav3_set_uhs_signaling, If you want. > }; > > static struct sdhci_pltfm_data sdhci_pxav3_pdata = { > - .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK > + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK Also not an improvement. Why change the space to a tab here? > @@ -343,7 +347,7 @@ static struct sdhci_pxa_platdata *pxav3_get_mmc_pdata(struct device *dev) > return NULL; > > if (!of_property_read_u32(np, "mrvl,clk-delay-cycles", > - &clk_delay_cycles)) > + &clk_delay_cycles)) Not an improvement, etc...