* [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu
@ 2015-09-02 2:24 Huang Shijie
2015-09-02 2:29 ` Jiang Liu
2015-09-22 14:18 ` [tip:irq/core] genirq: Remove the second parameter from handle_irq_event_percpu() tip-bot for Huang Shijie
0 siblings, 2 replies; 3+ messages in thread
From: Huang Shijie @ 2015-09-02 2:24 UTC (permalink / raw)
To: tglx; +Cc: jiang.liu, peterz, marc.zyngier, linux-kernel, Huang Shijie
Actually, we always use the first irq action of the @desc->action chain,
this patch remove the second parameter from handle_irq_event_percpu() which
makes the code more tidy.
Signed-off-by: Huang Shijie <shijie.huang@arm.com>
---
kernel/irq/chip.c | 2 +-
kernel/irq/handle.c | 7 +++----
kernel/irq/internals.h | 2 +-
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6e40a95..27e4833 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -680,7 +680,7 @@ handle_percpu_irq(unsigned int irq, struct irq_desc *desc)
if (chip->irq_ack)
chip->irq_ack(&desc->irq_data);
- handle_irq_event_percpu(desc, desc->action);
+ handle_irq_event_percpu(desc);
if (chip->irq_eoi)
chip->irq_eoi(&desc->irq_data);
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index b6eeea8..bc2f892 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -130,11 +130,11 @@ void __irq_wake_thread(struct irq_desc *desc, struct irqaction *action)
wake_up_process(action->thread);
}
-irqreturn_t
-handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
+irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
{
irqreturn_t retval = IRQ_NONE;
unsigned int flags = 0, irq = desc->irq_data.irq;
+ struct irqaction *action = desc->action;
do {
irqreturn_t res;
@@ -182,14 +182,13 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
irqreturn_t handle_irq_event(struct irq_desc *desc)
{
- struct irqaction *action = desc->action;
irqreturn_t ret;
desc->istate &= ~IRQS_PENDING;
irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
raw_spin_unlock(&desc->lock);
- ret = handle_irq_event_percpu(desc, action);
+ ret = handle_irq_event_percpu(desc);
raw_spin_lock(&desc->lock);
irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS);
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
index eee4b38..1be888c 100644
--- a/kernel/irq/internals.h
+++ b/kernel/irq/internals.h
@@ -81,7 +81,7 @@ extern void irq_mark_irq(unsigned int irq);
extern void init_kstat_irqs(struct irq_desc *desc, int node, int nr);
-irqreturn_t handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action);
+irqreturn_t handle_irq_event_percpu(struct irq_desc *desc);
irqreturn_t handle_irq_event(struct irq_desc *desc);
/* Resending of interrupts :*/
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu
2015-09-02 2:24 [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu Huang Shijie
@ 2015-09-02 2:29 ` Jiang Liu
2015-09-22 14:18 ` [tip:irq/core] genirq: Remove the second parameter from handle_irq_event_percpu() tip-bot for Huang Shijie
1 sibling, 0 replies; 3+ messages in thread
From: Jiang Liu @ 2015-09-02 2:29 UTC (permalink / raw)
To: Huang Shijie, tglx; +Cc: peterz, marc.zyngier, linux-kernel
On 2015/9/2 10:24, Huang Shijie wrote:
> Actually, we always use the first irq action of the @desc->action chain,
> this patch remove the second parameter from handle_irq_event_percpu() which
> makes the code more tidy.
>
> Signed-off-by: Huang Shijie <shijie.huang@arm.com>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> kernel/irq/chip.c | 2 +-
> kernel/irq/handle.c | 7 +++----
> kernel/irq/internals.h | 2 +-
> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index 6e40a95..27e4833 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -680,7 +680,7 @@ handle_percpu_irq(unsigned int irq, struct irq_desc *desc)
> if (chip->irq_ack)
> chip->irq_ack(&desc->irq_data);
>
> - handle_irq_event_percpu(desc, desc->action);
> + handle_irq_event_percpu(desc);
>
> if (chip->irq_eoi)
> chip->irq_eoi(&desc->irq_data);
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index b6eeea8..bc2f892 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -130,11 +130,11 @@ void __irq_wake_thread(struct irq_desc *desc, struct irqaction *action)
> wake_up_process(action->thread);
> }
>
> -irqreturn_t
> -handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
> +irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
> {
> irqreturn_t retval = IRQ_NONE;
> unsigned int flags = 0, irq = desc->irq_data.irq;
> + struct irqaction *action = desc->action;
>
> do {
> irqreturn_t res;
> @@ -182,14 +182,13 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
>
> irqreturn_t handle_irq_event(struct irq_desc *desc)
> {
> - struct irqaction *action = desc->action;
> irqreturn_t ret;
>
> desc->istate &= ~IRQS_PENDING;
> irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
> raw_spin_unlock(&desc->lock);
>
> - ret = handle_irq_event_percpu(desc, action);
> + ret = handle_irq_event_percpu(desc);
>
> raw_spin_lock(&desc->lock);
> irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS);
> diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
> index eee4b38..1be888c 100644
> --- a/kernel/irq/internals.h
> +++ b/kernel/irq/internals.h
> @@ -81,7 +81,7 @@ extern void irq_mark_irq(unsigned int irq);
>
> extern void init_kstat_irqs(struct irq_desc *desc, int node, int nr);
>
> -irqreturn_t handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action);
> +irqreturn_t handle_irq_event_percpu(struct irq_desc *desc);
> irqreturn_t handle_irq_event(struct irq_desc *desc);
>
> /* Resending of interrupts :*/
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:irq/core] genirq: Remove the second parameter from handle_irq_event_percpu()
2015-09-02 2:24 [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu Huang Shijie
2015-09-02 2:29 ` Jiang Liu
@ 2015-09-22 14:18 ` tip-bot for Huang Shijie
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Huang Shijie @ 2015-09-22 14:18 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, jiang.liu, linux-kernel, hpa, mingo, shijie.huang
Commit-ID: 71f64340fc0eadd06036d0db9a511b6d726add1d
Gitweb: http://git.kernel.org/tip/71f64340fc0eadd06036d0db9a511b6d726add1d
Author: Huang Shijie <shijie.huang@arm.com>
AuthorDate: Wed, 2 Sep 2015 10:24:55 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 22 Sep 2015 16:14:55 +0200
genirq: Remove the second parameter from handle_irq_event_percpu()
Actually, we always use the first irq action of the @desc->action
chain, so remove the second parameter from handle_irq_event_percpu()
which makes the code more tidy.
Signed-off-by: Huang Shijie <shijie.huang@arm.com>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: peterz@infradead.org
Cc: marc.zyngier@arm.com
Link: http://lkml.kernel.org/r/1441160695-19809-1-git-send-email-shijie.huang@arm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/chip.c | 2 +-
kernel/irq/handle.c | 7 +++----
kernel/irq/internals.h | 2 +-
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index e28169d..46f1fb5 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -669,7 +669,7 @@ void handle_percpu_irq(struct irq_desc *desc)
if (chip->irq_ack)
chip->irq_ack(&desc->irq_data);
- handle_irq_event_percpu(desc, desc->action);
+ handle_irq_event_percpu(desc);
if (chip->irq_eoi)
chip->irq_eoi(&desc->irq_data);
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index de41a68..ea7b5fd 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -132,11 +132,11 @@ void __irq_wake_thread(struct irq_desc *desc, struct irqaction *action)
wake_up_process(action->thread);
}
-irqreturn_t
-handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
+irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
{
irqreturn_t retval = IRQ_NONE;
unsigned int flags = 0, irq = desc->irq_data.irq;
+ struct irqaction *action = desc->action;
do {
irqreturn_t res;
@@ -184,14 +184,13 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
irqreturn_t handle_irq_event(struct irq_desc *desc)
{
- struct irqaction *action = desc->action;
irqreturn_t ret;
desc->istate &= ~IRQS_PENDING;
irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
raw_spin_unlock(&desc->lock);
- ret = handle_irq_event_percpu(desc, action);
+ ret = handle_irq_event_percpu(desc);
raw_spin_lock(&desc->lock);
irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS);
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
index 5ef0c2d..cd60bb4 100644
--- a/kernel/irq/internals.h
+++ b/kernel/irq/internals.h
@@ -81,7 +81,7 @@ extern void irq_mark_irq(unsigned int irq);
extern void init_kstat_irqs(struct irq_desc *desc, int node, int nr);
-irqreturn_t handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action);
+irqreturn_t handle_irq_event_percpu(struct irq_desc *desc);
irqreturn_t handle_irq_event(struct irq_desc *desc);
/* Resending of interrupts :*/
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-22 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02 2:24 [PATCH] genirq: Remove the second parameter from handle_irq_event_percpu Huang Shijie
2015-09-02 2:29 ` Jiang Liu
2015-09-22 14:18 ` [tip:irq/core] genirq: Remove the second parameter from handle_irq_event_percpu() tip-bot for Huang Shijie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).